Repository navigation
Fixes scrollToBottom method to properly handle calls made early in the view lifecycle - #1110
Merged
nathantannar4 merged 3 commits intoJul 8, 2019
Conversation
Member
|
Thanks @marcetcheverry , your reasoning makes sense. I will test this when I return from holiday. Sent with GitHawk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
—————————————————————————
Wanting to implement a default "scrolled to bottom" appearance I did something like this
(Let me know if there is a better way to do this)
However, I found that
collectionViewContentHeightwas often0inscrollToBottom, leading to this code not working unless it was called twice.This was the old implementation:
The documentation for
performBatchUpdatesstates:If the collection view's layout is not up to date before you call this method, a reload may occur.Therefore, moving the capturing of the collection view height to inside the block fixes the issue, as performBatchUpdates will ensure all basic layout is done and we have accurate data to work off.
Whatever you think of the implementation of the automatic scroll to bottom on first appearance, the fix for this issue is still valid, as calling this method before the first
reloadDataright now does not work, and this PR fixes that.Any other comments?
Not sure which branch to submit too, but I am using Swift 5.
Where has this been tested?
Devices/Simulators: iPhone XS
iOS Version: 12.2
Swift Version: Swift 5
MessageKit Version: 3.0.0-swif5
👻