Skip to content

InputTextView sizes incorrectly for long messages #129

Closed

Description

@SD10

screen shot 2017-09-16 at 8 00 24 pm

How to reproduce:

  1. Paste or type a large amount of text inside of the UITextView.

Something that will be greater than the the maxWidth allowed when calculating the intrinsicContentSize

Note: Reaching a maxWidth with new lines don't trigger this bug

Activity

  1. added this to the 0.8.0 milestone on Sep 18, 2017
  2. added a commit that references this issue on Sep 26, 2017
  3. Ganzolo commented on Sep 26, 2017

    @Ganzolo

    I just battled a lot with this issue. I think I found a fix with minimum impact on current code. I think the problem relies on UIKit. What I did is getting rid of intrinsicContentSize to change the height of view and only relies on :

    • Content Compression resistance
    • layout height constraint
  4. nathantannar4 commented on Sep 26, 2017

    @nathantannar4
    Member

    Hey,
    I looked over what you had and you left out some things. I don't think changing the entire intrinsicContentSize is needed. I have been doing some texting and I think adding a heightconstaint just to the InputTextView when height > maxHeight is all we need

  5. SD10 commented on Sep 28, 2017

    @SD10
    MemberAuthor

    This is fixed in #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions