Repository navigation
Fix unittest for read/write lock - #962
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes intermittent unit test failures in the read/write lock tests by adjusting timing thresholds to be less sensitive to execution timing variations.
Changes:
- Relaxed minimum duration assertion from 0.2s to 0.15s in writer/reader sequencing test
- Extended maximum duration assertion from 0.4s to 0.45s in lock collision test
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fixes intermittent unit test failures for the read/write lock caused by timing sensitivity. The test criteria are relaxed to reduce dependency on precise timing and improve overall stability. Also fix the issue that the java path should not be a fixed string because the latest java version will change. Use script to dynamically locate the path of the extracted java binary.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tianyang-Zhang
approved these changes
Jan 20, 2026
mwqgithub
approved these changes
Jan 21, 2026
o-love
pushed a commit
that referenced
this pull request
Jan 23, 2026
fixes intermittent unit test failures for the read/write lock caused by timing sensitivity. The test criteria are relaxed to reduce dependency on precise timing and improve overall stability. Also fix the issue that the java path should not be a fixed string because the latest java version will change. Use script to dynamically locate the path of the extracted java binary.
SarahScargall
pushed a commit
to SarahScargall/MemMachine
that referenced
this pull request
Jan 29, 2026
fixes intermittent unit test failures for the read/write lock caused by timing sensitivity. The test criteria are relaxed to reduce dependency on precise timing and improve overall stability. Also fix the issue that the java path should not be a fixed string because the latest java version will change. Use script to dynamically locate the path of the extracted java binary.
Merged
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Fix intermittent unit test failures.
Description
fixes intermittent unit test failures for the read/write lock caused by
timing sensitivity. The test criteria are relaxed to reduce dependency
on precise timing and improve overall stability.
Also fixes an issue where the Java path was hard-coded. Since the Java
version may change, the path is now determined dynamically by a script
that locates the extracted Java binary.
Type of change
How Has This Been Tested?
Checklist
Maintainer Checklist