Repository navigation
fix: confirm the Qdrant endpoint before writing wizard configuration - #1848
Open
DivyamTalwar wants to merge 1 commit into
Open
DivyamTalwar wants to merge 1 commit into
DivyamTalwar wants to merge 1 commit into
Conversation
Refs MemMachine#1791 Implemented and reviewed with OpenAI Codex. Signed-off-by: Divyam Talwar <divyamtalwar0@gmail.com>
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the change
The configuration wizard selects Qdrant when available but currently writes its default external endpoint without showing or confirming the server. This makes the storage destination explicit while keeping configuration generation offline.
Description
QdrantConfand serialize the same host and REST port shown to the user.Fixes/Closes
Fixes #1791. The separate capacity correction is intentionally outside this PR; this branch is independent of #1772.
Type of change
How Has This Been Tested?
Linux, Python 3.12, frozen dependencies:
Additional macOS documentation gate: Node 22
mint broken-linkspassed with no broken links. No live Qdrant service is needed or contacted for this offline workflow. Full repository pytest and the complete optional-dependency/OS matrix were not run locally.Reproduce the focused suite with
uv run --frozen pytest packages/server/server_tests/memmachine_server/installation -q.Checklist
Maintainer Checklist
Further comments
Implementation, code review, and validation were performed with OpenAI Codex under the contributor's authorization. Human self-review remains unchecked. The commit is signed off and has GitHub's verified signature. No human review or full CI result is claimed.