Repository navigation
fix: align shipped short-term memory capacity with component defaults - #1847
Open
DivyamTalwar wants to merge 1 commit into
Open
DivyamTalwar wants to merge 1 commit into
DivyamTalwar wants to merge 1 commit into
Conversation
Refs MemMachine#1772 Implemented and reviewed with OpenAI Codex. Signed-off-by: Divyam Talwar <divyamtalwar0@gmail.com>
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Normal installation examples and generated wizard configuration currently override the 64,000-character short-term-memory default with 500. That causes ordinary messages to reach the summarization threshold much earlier than the component and full configuration defaults imply.
Description
64000in the shipped CPU/GPU/Nebula/event samples, install documentation, Helm configuration, and retrieval-agent examples.0.2.0to0.2.1; keepappVersion: v0.2.6.Fixes/Closes
Fixes #1772. Related prior work: closed, unmerged #1821 proposed disabling short-term memory; this change keeps enablement intact. #1518 overlaps backend/example wiring, and #1720 concerns lifecycle behavior; neither scope is folded into this PR.
Type of change
How Has This Been Tested?
Linux, Python 3.12.14, frozen dependencies:
MemMachine._with_default_episodic_memory_confto 64000.ShortTermMemorywith the existing mocked LLM does not summarize at 501 characters or exactly 64000 total characters. One additional Unicode code point triggers exactly one call, both with and without a saved summary.git diff --checkpasses.Additional macOS validation:
helm lint deployments/helmpassed.helm templateoutput both loaded through the actualConfigurationmodel and default merge, with capacity 64000 and enablement preserved. Only the container log path was relocated to a temporary host directory for validation.mint broken-linkspassed with no broken links.Full base-environment
ty check packagesreports 23 unresolved imports for absent optional SDKs (sentence_transformers,nebulagraph_python,pymilvus,litellm,spacy), with no other diagnostic categories. The full optional-dependency and OS/Python matrix was not run locally.Checklist
Maintainer Checklist
Further comments
Implementation, code review, and validation were performed with OpenAI Codex under the contributor's authorization. Human self-review remains unchecked. The commit is signed off and has GitHub's verified signature. No latency improvement or full CI result is claimed.