Repository navigation
test: guard paired configuration and component defaults - #1846
Open
DivyamTalwar wants to merge 1 commit into
Open
DivyamTalwar wants to merge 1 commit into
DivyamTalwar wants to merge 1 commit into
Conversation
Add an explicit 26-pair scalar default manifest without constructing providers or changing runtime validation. Refs MemMachine#1723 Implemented and reviewed with OpenAI Codex. Signed-off-by: Divyam Talwar <divyamtalwar0@gmail.com>
7 of 12 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Configuration models and their component parameter models intentionally duplicate several scalar defaults. A change on only one side can silently make omitted values behave differently. This adds a focused regression guard for those declared pairs.
Description
Related issue
Refs #1723. This is the preventive default-parity portion, not a claim to resolve every configuration/component validation difference.
Type of change
How Has This Been Tested?
Linux, Python 3.12.14, the frozen repository base environment:
nebula5-python==5.2.2installed: focused configuration and RRF suite 184 passed, including all 26 manifest cases.git diff --checkpassed.k1from1.5to1.75, and Neo4jFalseto0, failed their exact cases. Both production files were restored byte-for-byte afterward.Reproduce the manifest with
uv run pytest packages/server/server_tests/memmachine_server/common/configuration/test_component_default_parity.py -q. Install the Nebula extra to exercise its seven entries. The complete optional-dependency and OS/Python CI matrix was not run locally.Checklist
Maintainer Checklist
Further comments
Implementation, code review, and validation were performed with OpenAI Codex on the contributor's authorization. The human self-review box remains unchecked. The commit carries a Signed-off-by trailer and GitHub's verified signature, created through the authenticated commit API. No human review or full CI pass is claimed.