feat(ts-client): support batch memory delete by yaleMemVerge · Pull Request #1266 · MemMachine/MemMachine

yaleMemVerge · 2026-03-25T10:34:08Z

Purpose of the change

Support deleting multiple memories in a single API call from the TypeScript client, aligning with the existing server-side batch delete capability.

Description

The server's DeleteEpisodicMemorySpec and DeleteSemanticMemorySpec already accept both a single ID (episodic_id/semantic_id) and a list (episodic_ids/semantic_ids). This PR updates the TS client's MemMachineMemory.delete() to expose that capability.

Fixes/Closes

Fixes #1249

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit Test
Manual verification (list step-by-step instructions)

Call memory.delete('id123', 'episodic') — single delete, backward compatible
Call memory.delete(['id123', 'id456'], 'episodic') — batch delete, sends episodic_ids array in payload
Call memory.delete([], 'episodic') — throws MemMachineAPIError client-side before any request is sent

Test Results: Verified locally against a running MemMachine server instance.

Checklist

I have signed the commit(s) within this pull request
My code follows the style guidelines of this project (See STYLE_GUIDE.md)
I have performed a self-review of my own code
My changes generate no new warnings
I have added unit tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I have checked my code and corrected any misspellings

Maintainer Checklist

Confirmed all checks passed
Contributor has signed the commit(s)
Reviewed the code
Run, Tested, and Verified the change(s) work as expected

Further comments

package-lock.json changes are from npm audit fix — upgrades flatted (3.3.3→3.4.2) and markdown-it (14.1.0→14.1.1) to address security advisories, along with peer dependency metadata corrections.

Copilot

Pull request overview

This PR extends the TypeScript client’s MemMachineMemory.delete() API to support batch deletion of episodic/semantic memories in a single request, aligning the client with the server’s existing *_ids delete fields.

Changes:

Widen memory.delete() to accept either a single ID (string) or multiple IDs (string[]).
Update delete request payload construction to send episodic_ids / semantic_ids.
Apply npm audit fix updates in package-lock.json (notably flatted and markdown-it upgrades).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File	Description
packages/ts-client/src/memory/memmachine-memory.ts	Exposes batch delete and adjusts delete payload format to use `*_ids`.
packages/ts-client/package-lock.json	Lockfile updates from `npm audit fix` (dependency/security metadata changes).

Files not reviewed (1)

packages/ts-client/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

packages/ts-client/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

packages/ts-client/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- `delete()` now accepts `string | string[]` for bulk episodic/semantic deletion - chore: run `npm audit fix` (flatted 3.3.3→3.4.2, markdown-it 14.1.0→14.1.1) Signed-off-by: yaleMemVerge <yale.sun@memverge.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

Files not reviewed (1)

packages/ts-client/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

Files not reviewed (1)

packages/ts-client/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

packages/ts-client/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Steve Scargall <37674041+sscargal@users.noreply.github.com>

sscargal

LGTM

yaleMemVerge requested a review from Copilot March 25, 2026 10:34

yaleMemVerge self-assigned this Mar 25, 2026

Copilot started reviewing on behalf of yaleMemVerge March 25, 2026 10:36 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Comment thread packages/ts-client/src/memory/memmachine-memory.ts

Comment thread packages/ts-client/src/memory/memmachine-memory.ts Outdated

yaleMemVerge force-pushed the mem-ts-client branch from 572ab6a to 4423f4f Compare March 25, 2026 10:47

yaleMemVerge requested a review from Copilot March 25, 2026 10:49

Copilot started reviewing on behalf of yaleMemVerge March 25, 2026 10:51 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Comment thread packages/ts-client/src/memory/memmachine-memory.ts

yaleMemVerge force-pushed the mem-ts-client branch from 4423f4f to 7ca70c7 Compare March 25, 2026 11:05

yaleMemVerge requested a review from Copilot March 25, 2026 11:05

Copilot started reviewing on behalf of yaleMemVerge March 25, 2026 11:08 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Comment thread packages/ts-client/src/memory/memmachine-memory.ts Outdated

Comment thread packages/ts-client/tests/memmachine-memory.spec.ts

feat(ts-client): support batch memory delete

6a22af3

- `delete()` now accepts `string | string[]` for bulk episodic/semantic deletion - chore: run `npm audit fix` (flatted 3.3.3→3.4.2, markdown-it 14.1.0→14.1.1) Signed-off-by: yaleMemVerge <yale.sun@memverge.com>

yaleMemVerge force-pushed the mem-ts-client branch from 7ca70c7 to 6a22af3 Compare March 25, 2026 11:24

yaleMemVerge requested a review from Copilot March 25, 2026 11:25

Copilot started reviewing on behalf of yaleMemVerge March 25, 2026 11:27 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

sscargal added this to the v0.3.4 milestone Mar 28, 2026

sscargal requested a review from Copilot March 28, 2026 19:43

Copilot started reviewing on behalf of sscargal March 28, 2026 19:45 View session

Copilot AI reviewed Mar 28, 2026

View reviewed changes

sscargal requested review from Copilot, jealous and sscargal April 13, 2026 20:12

sscargal modified the milestones: v0.3.4, v0.3.5 Apr 13, 2026

Copilot started reviewing on behalf of sscargal April 13, 2026 20:14 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread packages/ts-client/src/memory/memmachine-memory.ts Outdated

Comment thread packages/ts-client/src/memory/memmachine-memory.ts Outdated

sscargal and others added 2 commits April 17, 2026 12:07

Update packages/ts-client/src/memory/memmachine-memory.ts

4b5e5eb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Steve Scargall <37674041+sscargal@users.noreply.github.com>

Update packages/ts-client/src/memory/memmachine-memory.ts

e0c88f4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Steve Scargall <37674041+sscargal@users.noreply.github.com>

sscargal approved these changes Apr 17, 2026

View reviewed changes

sscargal merged commit b857249 into MemMachine:main Apr 17, 2026
45 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ts-client): support batch memory delete#1266

feat(ts-client): support batch memory delete#1266
sscargal merged 3 commits intoMemMachine:mainfrom
yaleMemVerge:mem-ts-client

yaleMemVerge commented Mar 25, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

sscargal left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

yaleMemVerge commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of the change

Description

Fixes/Closes

Type of change

How Has This Been Tested?

Checklist

Maintainer Checklist

Further comments

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

sscargal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yaleMemVerge commented Mar 25, 2026 •

edited

Loading