chore(ci): move Node 20 GitHub Actions jobs to Node 24#1230
chore(ci): move Node 20 GitHub Actions jobs to Node 24#1230DeoJin wants to merge 1 commit intoMemMachine:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to run on newer Node.js versions (22/24), aligning CI with the upcoming GitHub Actions Node 20 deprecation and keeping TypeScript client and docs validation jobs compatible.
Changes:
- Move TypeScript client test and publish workflows from Node 20.19.x to Node 24.x.
- Update docs validation workflow matrix from Node 20/22 to Node 22/24.
- Upgrade docs workflow actions to
actions/checkout@v4andactions/setup-node@v4.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ts-client-test.yml | Switch ts-client CI test job to Node 24.x. |
| .github/workflows/ts-client-publish.yml | Switch ts-client publish job to Node 24.x. |
| .github/workflows/docs-checks.yml | Update docs validation matrix to 22/24 and bump checkout/setup-node actions to v4. |
Comments suppressed due to low confidence (1)
.github/workflows/docs-checks.yml:86
- There are multiple trailing blank lines at the end of this workflow file (after the last step). Consider removing the extra empty lines to keep the YAML clean and reduce noisy diffs in future edits.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@DeoJin please sign your commit. I cannot merge it because the commit is not signed. |
sscargal
left a comment
There was a problem hiding this comment.
Please implement the suggestions. Thanks.
| # Step 1: Checkout the repository code | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v3 | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
We should move to v5 at a minimum, which now uses node 24. See https://github.com/actions/checkout. v6 is available.
| # Step 2: Set up Node.js for the current matrix version | ||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v3 | ||
| uses: actions/setup-node@v4 |
There was a problem hiding this comment.
We should move to v5 at a minimum, which uses node 24 as the default. See https://github.com/actions/setup-node for details. v6 is the latest.
Summary
Closes #1221
Validation
pm install (in packages/ts-client)
pm run build (in packages/ts-client)
ode -e "require('./dist/index.js'); console.log('ts-client dist import smoke test: ok')" (in packages/ts-client)
Note:
pm test -- --runInBand in packages/ts-client currently fails on the repo's existing Jest/ts-jest preset mismatch (Preset ts-jest not found), independent of this workflow-only change.