Skip to content

Implement SQLAlchemySegmentLinker#1205

Draft
edwinyyyu wants to merge 69 commits intoMemMachine:mainfrom
edwinyyyu:sqlalchemy_segment_linker
Draft

Implement SQLAlchemySegmentLinker#1205
edwinyyyu wants to merge 69 commits intoMemMachine:mainfrom
edwinyyyu:sqlalchemy_segment_linker

Conversation

@edwinyyyu
Copy link
Copy Markdown
Contributor

@edwinyyyu edwinyyyu commented Mar 10, 2026

Purpose of the change

Faster than Neo4j for queries.
No corrupted state on crash.

Description

Based on #1199.

Choices:

  • JSON/JSONB allows faster upserts. Filters are already scoped to queries so queries are fast. GIN indexes are not so useful right now. Another alternative is EAV properties table which requires more complexity but can be better for range filters.

Type of change

[Please delete options that are not relevant.]

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g., code style improvements, linting)
  • Documentation update
  • Project Maintenance (updates to build scripts, CI, etc., that do not affect the main project)
  • Security (improves security without changing functionality)

How Has This Been Tested?

  • Unit Test
  • Integration Test
  • End-to-end Test
  • Test Script (please provide)
  • Manual verification (list step-by-step instructions)

Checklist

  • I have signed the commit(s) within this pull request
  • My code follows the style guidelines of this project (See STYLE_GUIDE.md)
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • Confirmed all checks passed
  • Contributor has signed the commit(s)
  • Reviewed the code
  • Run, Tested, and Verified the change(s) work as expected

@edwinyyyu edwinyyyu force-pushed the sqlalchemy_segment_linker branch 5 times, most recently from a724574 to ced2263 Compare March 10, 2026 19:00
@edwinyyyu edwinyyyu mentioned this pull request Mar 10, 2026
26 tasks
@edwinyyyu edwinyyyu force-pushed the sqlalchemy_segment_linker branch 6 times, most recently from 5498137 to e540bde Compare March 13, 2026 00:05
@edwinyyyu edwinyyyu force-pushed the sqlalchemy_segment_linker branch from e540bde to a6954a9 Compare March 13, 2026 17:35
@edwinyyyu edwinyyyu force-pushed the sqlalchemy_segment_linker branch 10 times, most recently from 5d451f6 to 29d090d Compare March 18, 2026 03:30
@edwinyyyu
Copy link
Copy Markdown
Contributor Author

Still needs some performance fixes.

@edwinyyyu
Copy link
Copy Markdown
Contributor Author

Maybe lazy ownership transfer is more performant.

@edwinyyyu edwinyyyu force-pushed the sqlalchemy_segment_linker branch from 29d090d to e3961e2 Compare March 20, 2026 00:49
edwinyyyu added 29 commits April 8, 2026 17:20
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>

WIP: Clarity

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
@edwinyyyu edwinyyyu force-pushed the sqlalchemy_segment_linker branch from 3d2bab8 to 58909cb Compare April 9, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant