Skip to content

Add CI for the latest Qt5 and Qt6#149

Closed
iakov wants to merge 1 commit into
MeVisLab:masterfrom
iakov:master
Closed

Add CI for the latest Qt5 and Qt6#149
iakov wants to merge 1 commit into
MeVisLab:masterfrom
iakov:master

Conversation

@iakov
Copy link
Copy Markdown
Contributor

@iakov iakov commented Nov 11, 2023

Example CI workflow for Qt5.15 and Qt6.x builds on Ubuntu-latest worker.
Small additional change from make -j 2 to make -j $(nproc) is useful for self-hosted and larger Github runners.

echo "$QTDIR/bin" >> $GITHUB_PATH
echo "$pythonLocation/bin" >> $GITHUB_PATH

- name: Build PythonQt
Copy link
Copy Markdown
Contributor

@mrbean-bremen mrbean-bremen Nov 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to make this work as is, you probably have to create the generator and generate the code before building PythonQt, as PythonQt needs some of the generated files.
Or you would have to modify the project file so that PythonQt uses the headers generated for Qt5...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@usiems is currently working on the generator to make it work for Qt6 (it already works pretty good for 5.15, at least in that branch), so hopefully this may be possible some time not so far away. Another thing that would help of course would be to actually compile all of the generated sources, not only the part that is needed for PythonQt. I understand that this is something @YuriUfimtsev has on his to-do list?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion with @YuriUfimtsev, I think this PR should be split into two different. Qt6 to be postponed for a while, but Qt5 as you've mentioned requires generated_cpp. This would help to check both the generator and the PythonQt build with the latest Qt (later...), and Qt5.12 can be used to test new CI scenario ATM. Thus, @YuriUfimtsev is (once again) The Chosen One to fight against GHA build matrix (Ha-ha!).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! You probably read my related comment in response to The Chosen One (will have to call him that now 😁)

@iakov iakov marked this pull request as draft November 14, 2023 09:08
@YuriUfimtsev YuriUfimtsev mentioned this pull request Nov 17, 2023
@iakov
Copy link
Copy Markdown
Contributor Author

iakov commented Nov 18, 2023

Obsolete now. Can be closed. The only feature here is the unified workflow file example for both Qt6 and Qt5

@iakov iakov closed this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants