Skip to content

Retab#129

Merged
mrbean-bremen merged 1 commit into
MeVisLab:qt6from
jbowler:pull-request-129
Oct 14, 2023
Merged

Retab#129
mrbean-bremen merged 1 commit into
MeVisLab:qt6from
jbowler:pull-request-129

Conversation

@jbowler
Copy link
Copy Markdown
Contributor

@jbowler jbowler commented Oct 14, 2023

Expand all the tabs in non-binary source files.

Expand all the tabs in non-binary source files.

Signed-off-by: John Bowler <jbowler@acm.org>
@jbowler
Copy link
Copy Markdown
Contributor Author

jbowler commented Oct 14, 2023

The change for build/common.prf is in pull request #128

Copy link
Copy Markdown
Contributor

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. There remain inconsistencies in the formatting, but these have been there in the first place (as can be seen in the original code), so I'll merge this is as.

{
foreach (const AbstractMetaFunction *f, l) {
if ((f->compareTo(func) & AbstractMetaFunction::PrettySimilar) == AbstractMetaFunction::PrettySimilar)
if ((f->compareTo(func) & AbstractMetaFunction::PrettySimilar) == AbstractMetaFunction::PrettySimilar)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like here a tab should be 4 spaces - not that there is any consistent formatting here...

@mrbean-bremen mrbean-bremen merged commit c5e6260 into MeVisLab:qt6 Oct 14, 2023
@jbowler jbowler deleted the pull-request-129 branch October 14, 2023 16:21
mrbean-bremen pushed a commit to mrbean-bremen/pythonqt that referenced this pull request Oct 29, 2023
Expand all the tabs in non-binary source files
mrbean-bremen pushed a commit that referenced this pull request Oct 29, 2023
Expand all the tabs in non-binary source files
mrbean-bremen pushed a commit that referenced this pull request Nov 1, 2023
Expand all the tabs in non-binary source files
mrbean-bremen pushed a commit that referenced this pull request Nov 2, 2023
Expand all the tabs in non-binary source files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants