Skip to content

add conformance tests into client unit tests #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IlyaFaer merged 12 commits into from
Mar 31, 2020
Merged

add conformance tests into client unit tests #9

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ade9985
add conformance tests into client unit tests
Mar 25, 2020
f62c48e
align conformance tests with test data
Mar 26, 2020
edf84da
Merge branch 'v4_post_policies' into post_policy_conformance_tests
Mar 26, 2020
a630984
update conformance tests to avoid problems with json spaces and times…
Mar 26, 2020
1de8570
Merge branch 'v4_post_policies' into post_policy_conformance_tests
Mar 26, 2020
c8bce87
fix error with bounded hostnames
Mar 26, 2020
353e4e2
Merge branch 'v4_post_policies' into post_policy_conformance_tests
Mar 26, 2020
1c87755
fix conformance tests
Mar 27, 2020
0b14b3b
Merge branch 'v4_post_policies' into post_policy_conformance_tests
Mar 27, 2020
2597d29
change asserts order
Mar 27, 2020
7c4bd6c
fix conformance tests
Mar 30, 2020
2fd0025
merge unit test
Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update conformance tests to avoid problems with json spaces and times… 
…tamp Z-symbol violation
  • Loading branch information
IlyaFaer committed Mar 26, 2020
commit a6309846de1715eb69a1c2a4ce2b7fe4e9ce5022
33 changes: 21 additions & 12 deletions tests/unit/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import base64
import io
import json
import mock
Expand Down Expand Up @@ -1815,22 +1816,30 @@ def test_conformance_post_policy(test_data):
timestamp = datetime.datetime.strptime(in_data["timestamp"], "%Y-%m-%dT%H:%M:%SZ")

with mock.patch("google.cloud.storage._signing.NOW", return_value=timestamp):
policy = client.generate_signed_post_policy_v4(
credentials=_DUMMY_CREDENTIALS,
bucket_name=in_data["bucket"],
blob_name=in_data["object"],
conditions=in_data.get("conditions"),
fields=in_data.get("fields"),
expiration=in_data["expiration"],
virtual_hosted_style=in_data.get("urlStyle") == "VIRTUAL_HOSTED_STYLE",
bucket_bound_hostname=bucket_bound_hostname,
scheme=in_data.get("scheme"),
)
with mock.patch(
"google.cloud.storage.client.get_expiration_seconds_v4",
return_value=in_data["expiration"],
):
with mock.patch("google.cloud.storage.client._NOW", return_value=timestamp):
policy = client.generate_signed_post_policy_v4(
credentials=_DUMMY_CREDENTIALS,
bucket_name=in_data["bucket"],
blob_name=in_data["object"],
conditions=in_data.get("conditions"),
Comment thread
IlyaFaer marked this conversation as resolved.
Outdated
fields=in_data.get("fields"),
expiration=in_data["expiration"],
virtual_hosted_style=in_data.get("urlStyle")
== "VIRTUAL_HOSTED_STYLE",
bucket_bound_hostname=bucket_bound_hostname,
scheme=in_data.get("scheme"),
)
fields = policy["fields"]

assert policy["url"] == out_data["url"]
assert fields["x-goog-algorithm"] == out_fields["x-goog-algorithm"]
assert fields["x-goog-credential"] == out_fields["x-goog-credential"]
assert fields["x-goog-date"] == out_fields["x-goog-date"]
assert fields["x-goog-signature"] == out_fields["x-goog-signature"]
assert fields["policy"] == out_fields["policy"]

decoded_policy = base64.b64decode(fields["policy"]).decode()
assert decoded_policy == out_data["expectedDecodedPolicy"]