Repository navigation
fix: prevent duplicate concurrent fetches and white images in RasterizingLayer - #3357
Merged
Merged
Conversation
…ssues and improve style rendering fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Several issues were found while investigating failures in the rendering regression tests.
RasterizingLayer(main fix)GetFetchJobsnow returns an empty array whenactiveFetchCount > 0, matching the same guard already present inLayer.GetFetchJobs. Without this,DataFetcher.ViewportChangedAsynccould start a second rasterize task while the first was still loading data, causing the layer to render a white image.FetchJobID:FetchJobwas constructed with_sourceLayer.Idinstead of the rasterizing layer's ownId. This made theactiveFetchCountguard ineffective because job tracking is keyed by layer ID.TwoStepSymbolStyleRenderer/TwoStepVectorStyleRenderer(experimental renderer)ISkiaStyleRendereras a fallback for cache misses. AThemeStylecreates a new style instance on everyGetStyle()call, producing a newGenerationIdeach time — so the drawable cache always misses, and features were silently not rendered. The fallback delegates directly to the underlyingSymbolStyleRenderer/VectorStyleRendererand fixes this case (e.g.SelectionStyleSample).VisibleFeatureIteratorlayerStylesis now materialised to a list before iteration (minor cleanup, no behavioral change).CustomPointStyleShaderSampleMapsui.Rendering.Skia.MapRenderer. Added the matching registration onMapsui.Experimental.Rendering.Skia.MapRenderer, consistent withCustomPointStyleBasicSampleandCustomPointStyleAdvancedSample.Regression test config
config.json/config.local.jsonlookup.TestConfigurationnow reads only from the repository root, so there is a single authoritative config location.Skill / documentation
regression-testsskill to clarify that the copy-images script is for intentional rendering changes only, and that the experimental renderer must produce pixel-identical output to the standard renderer for all non-ExperimentalOnlySamplessamples.