Fix MAUI MapControl memory leak (SKGLView not released after navigation)#3273
Open
MereDoku wants to merge 3 commits intoMapsui:mainfrom
Open
Fix MAUI MapControl memory leak (SKGLView not released after navigation)#3273MereDoku wants to merge 3 commits intoMapsui:mainfrom
MereDoku wants to merge 3 commits intoMapsui:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3271
Summary
This PR fixes a memory leak in
Mapsui.Maui.MapControlwhereMapControland the underlyingSKGLViewwere not garbage collected after navigating away from a page.Repro
https://github.com/MereDoku/Mapsui.Maui.MemoryLeak.Repro
Changes
MyLocationLayeranimation on cleanupMapViewno longer keeps strong references after view is removedHow to test
VisualLeakCheckQueue.Monitor()MapControlandSKGLVieware collectedPlatforms tested