Repository navigation
[pull] master from git:master - #190
Merged
Merged
Conversation
Reading a counter with "cmd || echo 0" breaks whenever the command
writes output but still exits non-zero. On zero matches, "grep -c"
prints 0 and exits with status 1, so the command substitution
captured two zeros and the arithmetic that follows failed with a
syntax error instead of evaluating to 0.
Fix by ignoring the exit status with "|| true" and defaulting the
empty value with "${VAR:-0}". Apply this to ENTRY_COUNT in both
l10n_one_batch() and review_one_batch(), and to the BATCH counter
read from po/review-batch.txt, which used the same fragile fallback.
Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Task 3 claimed a gettext-only fallback, but validation already needs git-po-helper, and the awk|tac batch path fails on systems without tac. Require the helper for Tasks 3 and 4, drop the unused msgattrib/PO paths, and point agents at msg-select (with msgattrib still noted as an option). Pin to git-po-helper >= 0.9.1 to rely on new helper features: version comparison for the minimum version check, and `git-po-helper stat -c` used by the next commit to count PO entries. Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
grep -c on msgid lines only works for PO text, not GETTEXT JSON. When workflow intermediates move from PO to JSON, that count breaks. Use stat -c instead; it also excludes the header, so ENTRY_COUNT - 1 is unnecessary. Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Make/l10n compiles every po/*.po file. The AGENTS.md workflow keeps its intermediate files in po/, so any .po file written there can be picked up by a normal `make` run and cause build failures. Switch the workflow to use GETTEXT JSON for pending/input/review work files instead of PO, and rename the remaining PO scratch file to l10n-done.po.tmp so Make/l10n ignores it. This only affects the helper scripts documented in po/AGENTS.md. Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
The review_one_batch() function cleans up stale po/review-result*.json files before starting a new review. On zsh, an unmatched glob causes a "no matches found" error and aborts the command, because NOMATCH is on by default. Fix by enabling null_glob locally when running under zsh. This leaves bash and other POSIX shells unaffected, since $ZSH_VERSION is unset there. Only the cleanup step in review_one_batch() is changed; no other behavior is affected. Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Update following components: * bisect.c * builtin/add.c * builtin/bisect.c * builtin/branch.c * builtin/cat-file.c * builtin/checkout.c * builtin/commit.c * builtin/diff.c * builtin/fast-export.c * builtin/fast-import.c * builtin/fetch.c * builtin/history.c * builtin/multi-pack-index.c * builtin/mv.c * builtin/push.c * builtin/refs.c * builtin/repack.c * builtin/replay.c * builtin/repo.c * builtin/rev-list.c * builtin/worktree.c * bundle-uri.c * command-list.h * diff.c * git.c * imap-send.c * list-objects-filter.c * merge-ort.c * object-file.c * pack-bitmap.c * promisor-remote.c * remote.c * replay.c * setup.c * sequencer.c * transport-helper.c * usage.c * git-send-email.perl Translate following new components: * commit-reach.c * fetch-object-info.c * odb.c * odb/source-files.c * odb/transaction.c * odb/transaction.h Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
Signed-off-by: Peter Krefting <peter@softwolves.pp.se> Reviewed-by: Tuomas Ahola <taahol@utu.fi> Reviewed-by: AI, by way of Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
Signed-off-by: Emir SARI <emir_sari@icloud.com>
Signed-off-by: Aindriú Mac Giolla Eoin <aindriu80@gmail.com>
Signed-off-by: lilydjwg <lilydjwg@gmail.com>
Signed-off-by: lilydjwg <lilydjwg@gmail.com>
Signed-off-by: Mikel Forcada <mikel.forcada@gmail.com>
Co-authored-by: Kate Golovanova <kate@kgthreads.com> Signed-off-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> Signed-off-by: Kate Golovanova <kate@kgthreads.com>
Restore translations for the new translatable strings reintroduced by commit 0f8e75a (Revert "Merge branch 'en/no-amend-during-conflicts'", 2026-09-23). Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Add the initial Brazilian Portuguese translation of Git and register the language team in po/TEAMS. All 6476 messages are translated against the git.pot for v2.56.0-rc1. The file header carries a glossary documenting the terminology in use: Git command and concept names (branch, commit, merge, rebase, checkout, push, fetch, stash, tag, pack, worktree, ...) are kept in English while the surrounding prose is translated, and literal configuration values and command-line options are never translated. Signed-off-by: Daniel Pereira <danielmaraboo@gmail.com> Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Add a full Afrikaans translation of Git (6476 messages) and register the Afrikaans team in po/TEAMS. Signed-off-by: Stéfan Driaan Turvey <stefanturvey1912@gmail.com> Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Stéfan Driaan Turvey <stefanturvey1912@gmail.com>
l10n-2.56.0-v1 * tag 'l10n-2.56.0-v1' of https://github.com/git-l10n/git-po: l10n: af: fix review comments l10n: af: add Afrikaans translation l10n: pt_BR: add Brazilian Portuguese translation l10n: restore translations after upstream revert l10n: uk: add 2.56 translation l10n: Update Catalan Translation l10n: zh_CN: adopt review suggestions l10n: zh_CN: updated translation for 2.56 l10n: ga.po: update for Git 2.56 l10n: tr: Update Turkish translations l10n: fr: update translation for git 2.56.0 l10n: sv.po: Update Swedish translation l10n: po-id for 2.56 l10n: AGENTS.md: zsh-safe review result cleanup l10n: AGENTS.md: use JSON intermediates in workflow l10n: AGENTS.md: count PO entries with git-po-helper stat -c l10n: AGENTS.md: require git-po-helper >= 0.9.1 l10n: AGENTS.md: fix counter fallbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )