Fix SSL memory leak#237
Merged
Merged
Conversation
Refs bpo-34745, protocol and transport form circular reference, causing SSLContext stack up ugly.
1st1
approved these changes
Mar 17, 2019
Member
|
This is great, thank you! BTW, do you want to start porting this implementation to CPython? We almost have no time left until the feature freeze. |
Member
Author
|
@1st1 thanks for the merge! I'll port this fix to CPython today, and yes I've been working on the port of this SSL implementation to CPython, the process is kind of slow due to my limited time, I'm not 100% sure that it could catch up with the 4/28 or 5/26 deadline, but I'll try! |
Member
Author
|
The same fix comitted at python/cpython#12386 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs bpo-34745, protocol and transport form circular reference, causing
SSLContextstack up ugly.Before the fix:
After the fix:
The script to test: