Skip to content

Add type hint to entering PoolAcquireContext. #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robhaswell wants to merge 2 commits into from
+1 −1
Closed

Add type hint to entering PoolAcquireContext. #763

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51bb92f
Allow type checkers to determine that entering a PoolAcquireContext r…
May 26, 2021
e778700
Merge branch 'master' into pool-connection-types
robhaswell Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Allow type checkers to determine that entering a PoolAcquireContext r… 
…eturns a Connection.
  • Loading branch information
Rob Haswell committed May 26, 2021
commit 51bb92fcf0fd1cf3d6478d3b82cacb0231cd3951
2 changes: 1 addition & 1 deletion asyncpg/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@ def __init__(self, pool, timeout):
self.connection = None
self.done = False

async def __aenter__(self):
async def __aenter__(self) -> connection.Connection:
if self.connection is not None or self.done:
raise exceptions.InterfaceError('a connection is already acquired')
self.connection = await self.pool._acquire(self.timeout)
Expand Down