Skip to content

Pool: prevent trimming the last idle connection under load #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mamfyou wants to merge 6 commits into
base: master
Choose a base branch
from
+49 −0
Open

Pool: prevent trimming the last idle connection under load #1271

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b4b950c
pool: prevent trimming the last idle connection under load
Aug 18, 2025
48dea1e
pool: prevent trimming the last idle connection under load
Aug 18, 2025
e327332
Merge remote-tracking branch 'origin/fix-empty-connection-pool' into …
Aug 18, 2025
2c95068
pool: prevent trimming the last idle connection under load
Aug 28, 2025
3231508
feat: moved the guard function to Pool class and made some improvemen…
mamfyou Dec 24, 2025
b71ef44
chore: fixing typo in method name
mamfyou Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: fixing typo in method name
  • Loading branch information
@mamfyou
mamfyou committed Dec 24, 2025
commit b71ef44487dabe4f912792d5747f4c23d6cb079d
2 changes: 1 addition & 1 deletion asyncpg/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ def _deactivate_inactive_connection(self) -> None:

if self._con is not None:
# Only deactivate if doing so respects pool size and demand constraints.
if not self._pool.is_safe_to_close_connection():
if not self._pool.safe_to_close_connection():
# Still mark this holder as available and keep the connection.
# Re-arm the inactivity timer so we can reevaluate later.
self._setup_inactive_callback()
Expand Down