Skip to content

Add typing to _ConnectionParameters and related functions #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanielNoord wants to merge 8 commits into
base: master
Choose a base branch
from
+60 −37
Open

Add typing to _ConnectionParameters and related functions #1199

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
92f3ae6
Add type annotations to `_validate_port_spec`
DanielNoord Oct 23, 2024
0983306
Add type annotations to `_parse_hostlist`
DanielNoord Oct 23, 2024
ffd8087
Fix and improve typing of `_read_password_from_pgpass`
DanielNoord Oct 23, 2024
ea9cb59
Ensure `query` is always `dict[str, str]`
DanielNoord Oct 23, 2024
d27cbcd
Refactor `SSLMode.parse` so type checkers undertstand it
DanielNoord Oct 23, 2024
4ba71c8
Add type annotations to `_ConnectionParameters` and its constructing …
DanielNoord Oct 23, 2024
294e6bc
Remove stringified annotations after future import
DanielNoord Oct 29, 2024
ccf181a
Remove more stringified annotations
DanielNoord Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure query is always dict[str, str]
  • Loading branch information
@DanielNoord
DanielNoord committed Oct 29, 2024
commit ea9cb59d5a8b79e7e6f92d5e09042da70165b1aa
10 changes: 6 additions & 4 deletions asyncpg/connect_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,10 +325,12 @@ def _parse_connect_dsn_and_args(*, dsn, host, port, user,
password = urllib.parse.unquote(dsn_password)

if parsed.query:
query = urllib.parse.parse_qs(parsed.query, strict_parsing=True)
for key, val in query.items():
if isinstance(val, list):
query[key] = val[-1]
query = {
key: val[-1]
for key, val in urllib.parse.parse_qs(
parsed.query, strict_parsing=True
).items()
}

if 'port' in query:
val = query.pop('port')
Expand Down