Delete build.sh & merge ROS1/2 into one package - #46

#26

I've tested this on ROS noetic with catkin_make from the top level and believe this is the correct way to do building. Please follow the ROS conventions rather than using a build script as @Ericsii has done.

The PR required the following modification to package.xml

git diff package.xml
diff --git a/package.xml b/package.xml
index 19b5804..ff7cf81 100644
--- a/package.xml
+++ b/package.xml
@@ -11,9 +11,9 @@
 
     <!-- ROS1 dependencies -->
     <buildtool_depend condition="$ROS_VERSION == 1">catkin</buildtool_depend>
-    <build_depend condition="$ROS_VERSION == 1">roscpp</build_depend>
-    <build_depend condition="$ROS_VERSION == 1">rospy</build_depend>
-    <build_depend condition="$ROS_VERSION == 1">message_generation</build_depend>
+    <depend condition="$ROS_VERSION == 1">roscpp</depend>
+    <depend condition="$ROS_VERSION == 1">rospy</depend>
+    <depend condition="$ROS_VERSION == 1">message_generation</depend>
     <exec_depend condition="$ROS_VERSION == 1">message_runtime</exec_depend>
     <exec_depend condition="$ROS_VERSION == 1">rosbag</exec_depend>

I've also tested under ROS2 humble with colcon build from the workspace dir and it works.

Awesome!

Although to be complete you might also update the instructions in the README.md.

Funny how these lidar manufacturers handle ignore these PRs: RoboSense-LiDAR/rslidar_sdk#48
They seem to think the whole software stack/build system revolves around the sensor driver.

Thx for this!
One question though, ROS2 releases older than Humble are deprecated now: https://dlu.github.io/ros_clock/index.html
Hence, can we ditch the if-guard here?
https://github.com/Ericsii/livox_ros_driver2/blob/6f1a61e785452170a195887400f1d2950c5abfb8/CMakeLists.txt#L285
Which checks for Humble only, but in principle should also be used on Iron and Rolling as well.

Hence, can we ditch the if-guard here? https://github.com/Ericsii/livox_ros_driver2/blob/6f1a61e785452170a195887400f1d2950c5abfb8/CMakeLists.txt#L285 Which checks for Humble only, but in principle should also be used on Iron and Rolling as well.

Sure, I think this could be removed. But I need some tests on Iron and Rolling

Verified on iron 🙂

@MCFurry I removed the condition for humble. It might work in newer versions of ros2

We noticed! Thanks for that! Seems to work fine for Iron now as well.

Although we're also using https://github.com/pixmoving-auto/Livox-SDK2.git on update/robobus branch for the time being, since then both packages are ROS-packages and can now be easily automatically installed.

That being said, that implementation can slightly be improved by keeping it a pure cmake package and only add a package.xml file 🙂

hello, i fail to build the file using colcon build. how can you do that, it showed that "CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files:
/root/PycharmProject/livox_ros_driver2-master/ws_livox/src/livox_ros_driver2/LIVOX_INTERFACES_INCLUDE_DIRECTORIES
used as include directory in directory /root/PycharmProject/livox_ros_driver2-master/ws_livox/src/livox_ros_driver2"

Sorry. I was interested in this PR and when I was checking it, I made an approve by mistake.

Sorry. I was interested in this PR and when I was checking it, I made an approve by mistake.

That's okay, a lot of people seem interested in this PR. If someone could actually merge this that would help out a lot of people out there! 😉

Thanks for the PR. I'm switching our workspace to your branch to be able to build the package in a standard way :)

It works well on both Jazzy and Kilted!

@Livox-Infra Please have a look at this PR. It would greatly simplify lifes of your users.

@Ericsii - works on Jazzy.

This is also resulting in these kind of headaches:
https://github.com/RoboStack/ros-rolling/blob/main/rosdistro_additional_recipes.yaml#L11

@Livox-louie as last committer. What do you think of this thread?
Seems like there is enough animo from the community to get this fixed?