Skip to content

Clarify that wildcard and credentials are mutually exclusive - #2210

Merged
Kludex merged 3 commits into
Kludex:masterfrom
dfioravanti:patch-1
Dec 16, 2023
Merged

Kludex merged 3 commits into
Kludex:masterfrom
dfioravanti:patch-1

Conversation

@dfioravanti

@dfioravanti dfioravanti commented Jul 7, 2023 •

Copy link
Copy Markdown
Contributor

Summary

According to the Mozilla documentation. Wildcards cannot be used in conjunction with credentials in CORS requests. See: https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#credentialed_requests_and_wildcards

More details in: #2206

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex
Kludex requested a review from alex-oleshkevich July 7, 2023 12:27
@dfioravanti

Copy link
Copy Markdown
Contributor Author

Ah actually by reading the documentation better I realized that one cannot use * in any of the allow. Let me amend this

@dfioravanti
dfioravanti force-pushed the patch-1 branch 2 times, most recently from e026b7f to 3861d3a Compare July 7, 2023 12:45
@dfioravanti

Copy link
Copy Markdown
Contributor Author

Done, now the documentation is better aligned with the actual standard

@dfioravanti dfioravanti changed the title Clarify that all origins and allow credentials are mutually exclusive Clarify that widecards and allow_credentials set to true are mutually exclusive Jul 7, 2023
@dfioravanti dfioravanti changed the title Clarify that widecards and allow_credentials set to true are mutually exclusive Clarify that widecards and credentials are mutually exclusive Jul 7, 2023
According to the Mozilla documentation, wildcards cannot be used in conjunction with credentials in CORS requests.
See: https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#credentialed_requests_and_wildcards
@Kludex Kludex changed the title Clarify that widecards and credentials are mutually exclusive Clarify that wildcard and credentials are mutually exclusive Sep 14, 2023
Comment thread docs/middleware.md Resolved
@Kludex
Kludex enabled auto-merge (squash) December 16, 2023 14:39
@Kludex
Kludex merged commit a2a3df3 into Kludex:master Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants