Repository navigation
Conversation
Reserve the 63px header offset so all store filters remain reachable.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #390
The store sidebar starts 63px below the viewport top but previously used the full viewport height, leaving its bottom 63px off-screen even at maximum scroll. Subtract the existing top offset from its height so the final category and suggestion link remain reachable.
Validation: an isolated browser fixture using the actual menu HTML and project styles passed seven cases: six viewports from 1920×1080 to 640×360 with long category lists, plus a short-list case. The original CSS overflowed by 63px; the corrected CSS fits the viewport, with the final category hit-testable and its checkbox selectable.
git diff --checkpassed.Full application/e2e tests, actual browser zoom and Safari were not run. The fixture uses synthetic categories and does not exercise backend filtering or install modules.
AI assistance: OpenAI Codex helped prepare and validate this change.