Adding pydata Tel Aviv - #3
Merged
Merged
Conversation
JesperDramsch
approved these changes
Sep 7, 2022
JesperDramsch
left a comment
Owner
There was a problem hiding this comment.
Thanks for submitting this!
LGTM
JesperDramsch
pushed a commit
that referenced
this pull request
Jan 19, 2026
Bug #1: PR Detection Missing - Added comprehensive PR search that checks for ANY open PR related to a conference, not just PRs from the accumulator branch - Search matches by conference name, slug, URL domain in PR titles, bodies, and branch names - Uses Python for safe string matching to prevent injection issues Bug #2: Heredoc Delimiter Collision - Replaced heredoc approach with file-based content storage - Use base64 encoding for diff content passed between jobs - Claude Code Action now reads content from temp files using Read tool - This prevents crashes when scraped content contains delimiter strings, special characters, or encoding issues Bug #3: Duplicate Workflow Triggers - Changed concurrency group from global to per-conference - Group key: conference-update-{watch_uuid|url|run_id} - Different conferences can now run in parallel - Same conference serializes to prevent race conditions Additional: Payload Validation - Added validation step at start of zone-check job - Fails fast with clear error messages if required fields missing - Helps diagnose issues like expired PAT tokens - Provides helpful summary output for debugging
JesperDramsch
added a commit
that referenced
this pull request
Jan 19, 2026
* fix: address conference update pipeline bugs Bug #1: PR Detection Missing - Added comprehensive PR search that checks for ANY open PR related to a conference, not just PRs from the accumulator branch - Search matches by conference name, slug, URL domain in PR titles, bodies, and branch names - Uses Python for safe string matching to prevent injection issues Bug #2: Heredoc Delimiter Collision - Replaced heredoc approach with file-based content storage - Use base64 encoding for diff content passed between jobs - Claude Code Action now reads content from temp files using Read tool - This prevents crashes when scraped content contains delimiter strings, special characters, or encoding issues Bug #3: Duplicate Workflow Triggers - Changed concurrency group from global to per-conference - Group key: conference-update-{watch_uuid|url|run_id} - Different conferences can now run in parallel - Same conference serializes to prevent race conditions Additional: Payload Validation - Added validation step at start of zone-check job - Fails fast with clear error messages if required fields missing - Helps diagnose issues like expired PAT tokens - Provides helpful summary output for debugging * fix: use file-based PR detection for conference updates Instead of fuzzy matching PR titles/branches/bodies, now: 1. Find all open PRs that modify _data/conferences.yml 2. For each, check if the diff actually includes this conference 3. Only skip if a PR genuinely modifies this specific conference This is more precise and avoids false positives from generic "conference updates" PRs or branch naming conventions. * feat: add trigger context to triage workflow The scheduled extension checker now passes context to triage: - trigger_reason: extension_check, closing_soon, closing_today, or website_change - original_cfp_deadline: the CFP date that triggered the check The triage workflow uses this context to: - Build a focused prompt for extension checks (vs general website changes) - Log clearly when no extension was found (avoids spurious PRs) - Include deadline info in step summary for debugging This helps distinguish between changedetection.io webhooks (general website monitoring) and scheduled CFP extension checks (specific focus). --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding PyData Tel Aviv 2022