Switch to new DC::tot bank#645
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to switch the data bank for the DC detector from the old tdc bank ("DC::tdc") to the new tot bank ("DC::tot") and includes several removals of legacy Bos, detector decode, physics, and plotting classes. Key changes include updating the default value for tdcToT in detector data, modifying conditional checks and bank name arrays in CLASDecoder4, and removing a number of deprecated files no longer needed for the new implementation.
Reviewed Changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| common-tools/clas-detector/src/main/java/org/jlab/detector/decode/DetectorDataDgtz.java | Updates tdcToT default value to -1 to signal an unset or missing value. |
| common-tools/clas-detector/src/main/java/org/jlab/detector/decode/CLASDecoder4.java | Updates string comparisons and the bank names array to use "DC::tot" instead of "DC::tdc". |
| [Multiple Legacy Files] | Removal of legacy Bos, detector decode, physics, and plotting classes no longer required. |
e1f177d to
bca7ac5
Compare
…needed to handle DC::tdc and DC::tot
Closed
raffaelladevita
approved these changes
May 29, 2025
c-dilks
pushed a commit
that referenced
this pull request
Sep 15, 2025
* detect based on schema * remove broken methods * remove old decoder and associations * add DC::tot bank schema * remove unused class * remove unused class * remove unused class * change default ToT=-1, for old firmware * write DC::tot instead of DC::tdc * short data types * detect firmware type * simplify * debug * remove unused classes * move class * remove unused classes * remove unused analysis classes * remove unused classes * more gitignore * fix oops * restore (for test deltas) * restore original type * more gitignore * add new bank to schemas * swaps for DC::tot * bg merging can now handle multiple/different raw banks per detector, needed to handle DC::tdc and DC::tot * remove unused dependency --------- Co-authored-by: Raffaella De Vita <devita@ge.infn.it>
tongtongcao
pushed a commit
that referenced
this pull request
Sep 22, 2025
* detect based on schema * remove broken methods * remove old decoder and associations * add DC::tot bank schema * remove unused class * remove unused class * remove unused class * change default ToT=-1, for old firmware * write DC::tot instead of DC::tdc * short data types * detect firmware type * simplify * debug * remove unused classes * move class * remove unused classes * remove unused analysis classes * remove unused classes * more gitignore * fix oops * restore (for test deltas) * restore original type * more gitignore * add new bank to schemas * swaps for DC::tot * bg merging can now handle multiple/different raw banks per detector, needed to handle DC::tdc and DC::tot * remove unused dependency --------- Co-authored-by: Raffaella De Vita <devita@ge.infn.it>
tongtongcao
pushed a commit
that referenced
this pull request
Nov 18, 2025
* detect based on schema * remove broken methods * remove old decoder and associations * add DC::tot bank schema * remove unused class * remove unused class * remove unused class * change default ToT=-1, for old firmware * write DC::tot instead of DC::tdc * short data types * detect firmware type * simplify * debug * remove unused classes * move class * remove unused classes * remove unused analysis classes * remove unused classes * more gitignore * fix oops * restore (for test deltas) * restore original type * more gitignore * add new bank to schemas * swaps for DC::tot * bg merging can now handle multiple/different raw banks per detector, needed to handle DC::tdc and DC::tot * remove unused dependency --------- Co-authored-by: Raffaella De Vita <devita@ge.infn.it>
tongtongcao
pushed a commit
that referenced
this pull request
Nov 21, 2025
* detect based on schema * remove broken methods * remove old decoder and associations * add DC::tot bank schema * remove unused class * remove unused class * remove unused class * change default ToT=-1, for old firmware * write DC::tot instead of DC::tdc * short data types * detect firmware type * simplify * debug * remove unused classes * move class * remove unused classes * remove unused analysis classes * remove unused classes * more gitignore * fix oops * restore (for test deltas) * restore original type * more gitignore * add new bank to schemas * swaps for DC::tot * bg merging can now handle multiple/different raw banks per detector, needed to handle DC::tdc and DC::tot * remove unused dependency --------- Co-authored-by: Raffaella De Vita <devita@ge.infn.it>
tongtongcao
pushed a commit
that referenced
this pull request
Dec 5, 2025
* detect based on schema * remove broken methods * remove old decoder and associations * add DC::tot bank schema * remove unused class * remove unused class * remove unused class * change default ToT=-1, for old firmware * write DC::tot instead of DC::tdc * short data types * detect firmware type * simplify * debug * remove unused classes * move class * remove unused classes * remove unused analysis classes * remove unused classes * more gitignore * fix oops * restore (for test deltas) * restore original type * more gitignore * add new bank to schemas * swaps for DC::tot * bg merging can now handle multiple/different raw banks per detector, needed to handle DC::tdc and DC::tot * remove unused dependency --------- Co-authored-by: Raffaella De Vita <devita@ge.infn.it>
tongtongcao
pushed a commit
that referenced
this pull request
Dec 5, 2025
* detect based on schema * remove broken methods * remove old decoder and associations * add DC::tot bank schema * remove unused class * remove unused class * remove unused class * change default ToT=-1, for old firmware * write DC::tot instead of DC::tdc * short data types * detect firmware type * simplify * debug * remove unused classes * move class * remove unused classes * remove unused analysis classes * remove unused classes * more gitignore * fix oops * restore (for test deltas) * restore original type * more gitignore * add new bank to schemas * swaps for DC::tot * bg merging can now handle multiple/different raw banks per detector, needed to handle DC::tdc and DC::tot * remove unused dependency --------- Co-authored-by: Raffaella De Vita <devita@ge.infn.it>
tongtongcao
pushed a commit
that referenced
this pull request
Dec 31, 2025
* detect based on schema * remove broken methods * remove old decoder and associations * add DC::tot bank schema * remove unused class * remove unused class * remove unused class * change default ToT=-1, for old firmware * write DC::tot instead of DC::tdc * short data types * detect firmware type * simplify * debug * remove unused classes * move class * remove unused classes * remove unused analysis classes * remove unused classes * more gitignore * fix oops * restore (for test deltas) * restore original type * more gitignore * add new bank to schemas * swaps for DC::tot * bg merging can now handle multiple/different raw banks per detector, needed to handle DC::tdc and DC::tot * remove unused dependency --------- Co-authored-by: Raffaella De Vita <devita@ge.infn.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.