Add V8 issue reference

kgryte · kgryte · commit 4b6abf3e98db · 2016-10-29T02:34:05.000-07:00
diff --git a/docs/native_math_bugs.md b/docs/native_math_bugs.md
@@ -6,7 +6,7 @@
 * [Trigonometric functions in V8][@chromium:320097]
 * [V8 not IEEE 754-2008 compliant][@v8:3089]
 * [Mozilla discussion on sine and cosine in V8][@bugzilla:967709]
-* [V8 replaced a lookup table by computing `Math.tan` as `Math.sin/Math.cos`][5]
+* [V8 replaced a lookup table by computing `Math.tan` as `Math.sin/Math.cos`][@chromium:78263005]
 * [Browser math accuracy issues][6]
 * [ES6 accuracy of special functions][7]
 * [Accuracy of `Math.exp` in V8][8]
@@ -35,7 +35,7 @@
 [@chromium:320097]: https://bugs.chromium.org/p/chromium/issues/detail?id=320097
 [@v8:3089]: https://bugs.chromium.org/p/v8/issues/detail?id=3089
 [@bugzilla:967709]: https://bugzilla.mozilla.org/show_bug.cgi?id=967709
-[5]: https://github.com/v8/v8/commit/33b5db090258c2a2dc825659c3ad109bd02110c1
+[@chromium:78263005]: https://github.com/v8/v8/commit/33b5db090258c2a2dc825659c3ad109bd02110c1
 [6]: https://github.com/kangax/compat-table/issues/392
 [7]: https://esdiscuss.org/topic/es6-accuracy-of-special-functions
 [8]: https://bugs.chromium.org/p/v8/issues/detail?id=3468
diff --git a/docs/references/bib.bib b/docs/references/bib.bib
@@ -743,10 +743,18 @@ @misc{v8:3089
 	year = {2014}
 }
 
-@misc{mozilla:967709,
+@misc{bugzilla:967709,
 	abstract = {On the attached microbenchmark, which just pounds on sin with non-repeating values, V8 is about 2.8x faster on my Linux machine. (Our sin/cos just call in the C stdlib's sin/cos, so this is highly dependent on OS and stdlib version. I'd appreciate seeing what numbers other people get.) Profiling the box2d benchmark on awfy shows about 50% of its time is just calling sin/cos and this gives V8 better overall throughput on my machine. It looks like V8 rolls their own sin/cos (https://code.google.com/p/v8/source/detail?r=17594) which gives them more predictable performance. They self-host sin/cos which also avoids the call out from JIT code and all the overhead that that incurs. Since the sin/code code isn't all that complex, it seems like we could do even better with MSin/MCos MIR/LIR ops.},
 	keywords = {mozilla, firefox, ff, math, sine, sin, cosine, cos, trig, bug, performance, perf},
 	title = {{V8 is 2.8x faster at sin/cos}},
 	url = {https://bugzilla.mozilla.org/show_bug.cgi?id=967709#c33},
 	year = {2014}
 }
+
+@misc{chromium:78263005,
+	abstract = {Embed trigonometric lookup table.},
+	keywords = {math, v8, chrome, sine, sin, cosine, cos, tan, tangent, trig, trigonometry, algorithm, algo},
+	title = {{Reland: Embed trigonometric lookup table.}},
+	url = {https://github.com/v8/v8/commit/33b5db090258c2a2dc825659c3ad109bd02110c1},
+	year = {2013}
+}
