Skip to content

Commit 5cec516

Browse files
committed
Add bugzilla issue reference
1 parent af54731 commit 5cec516

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

docs/native_math_bugs.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* [Sine and cosine in V8][@v8:3006]
66
* [Trigonometric functions in V8][@chromium:320097]
77
* [V8 not IEEE 754-2008 compliant][@v8:3089]
8-
* [Mozilla discussion on sine and cosine in V8][4]
8+
* [Mozilla discussion on sine and cosine in V8][@bugzilla:967709]
99
* [V8 replaced a lookup table by computing `Math.tan` as `Math.sin/Math.cos`][5]
1010
* [Browser math accuracy issues][6]
1111
* [ES6 accuracy of special functions][7]
@@ -34,7 +34,7 @@
3434
[@v8:3006]: https://bugs.chromium.org/p/v8/issues/detail?id=3006
3535
[@chromium:320097]: https://bugs.chromium.org/p/chromium/issues/detail?id=320097
3636
[@v8:3089]: https://bugs.chromium.org/p/v8/issues/detail?id=3089
37-
[4]: https://bugzilla.mozilla.org/show_bug.cgi?id=967709#c33
37+
[@bugzilla:967709]: https://bugzilla.mozilla.org/show_bug.cgi?id=967709
3838
[5]: https://github.com/v8/v8/commit/33b5db090258c2a2dc825659c3ad109bd02110c1
3939
[6]: https://github.com/kangax/compat-table/issues/392
4040
[7]: https://esdiscuss.org/topic/es6-accuracy-of-special-functions

docs/references/bib.bib

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -742,3 +742,11 @@ @misc{v8:3089
742742
url = {https://bugs.chromium.org/p/v8/issues/detail?id=3089},
743743
year = {2014}
744744
}
745+
746+
@misc{mozilla:967709,
747+
abstract = {On the attached microbenchmark, which just pounds on sin with non-repeating values, V8 is about 2.8x faster on my Linux machine. (Our sin/cos just call in the C stdlib's sin/cos, so this is highly dependent on OS and stdlib version. I'd appreciate seeing what numbers other people get.) Profiling the box2d benchmark on awfy shows about 50% of its time is just calling sin/cos and this gives V8 better overall throughput on my machine. It looks like V8 rolls their own sin/cos (https://code.google.com/p/v8/source/detail?r=17594) which gives them more predictable performance. They self-host sin/cos which also avoids the call out from JIT code and all the overhead that that incurs. Since the sin/code code isn't all that complex, it seems like we could do even better with MSin/MCos MIR/LIR ops.},
748+
keywords = {mozilla, firefox, ff, math, sine, sin, cosine, cos, trig, bug, performance, perf},
749+
title = {{V8 is 2.8x faster at sin/cos}},
750+
url = {https://bugzilla.mozilla.org/show_bug.cgi?id=967709#c33},
751+
year = {2014}
752+
}

0 commit comments

Comments
 (0)