fix: remove broken bech32 nsec/npub stub functions#16
Merged
melvincarvalho merged 1 commit intoMay 13, 2026
Merged
Conversation
The privateKeyToNsec, nsecToPrivateKey, and publicKeyToNpub functions emitted fake nsec_<hex> / npub_<hex> strings that are not valid NIP-19 bech32 encoding. These stubs could confuse users into thinking they have a valid key backup, and any interoperability with other Nostr clients would silently fail. The functions are not imported or called anywhere in the codebase, so they are removed entirely rather than replaced with throwing stubs. Proper NIP-19 bech32 support can be added when needed via a bech32 library. Co-Authored-By: claude-flow <ruv@ruv.net>
There was a problem hiding this comment.
Pull request overview
This PR removes misleading, non-compliant NIP-19 “bech32” stub helpers from src/crypto.js that were returning nsec_<hex> / npub_<hex> placeholder strings (not valid bech32), reducing the risk of users treating those strings as real backups/identifiers.
Changes:
- Deleted
privateKeyToNsec,nsecToPrivateKey, andpublicKeyToNpubstub exports fromsrc/crypto.js. - Left the actual key generation/signing/validation code paths unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/crypto.js:privateKeyToNsec,nsecToPrivateKey, andpublicKeyToNpubnsec_<hex>/npub_<hex>strings that are NOT valid NIP-19 bech32 encoding, which could confuse users into thinking they have a valid key backup@scure/base)Test plan
🤖 Generated with claude-flow