Skip to content

fix: remove unused webRequest permission#13

Merged
melvincarvalho merged 1 commit into
JavaScriptSolidServer:mainfrom
jjohare:fix/remove-unused-webrequest
May 12, 2026
Merged

fix: remove unused webRequest permission#13
melvincarvalho merged 1 commit into
JavaScriptSolidServer:mainfrom
jjohare:fix/remove-unused-webrequest

Conversation

@jjohare
Copy link
Copy Markdown

@jjohare jjohare commented May 12, 2026

Summary

  • Removes the webRequest permission from manifest.json — it is declared but never used anywhere in the codebase
  • The background script explicitly comments that webRequestBlocking is deprecated in MV3 and the extension uses JavaScript-level fetch/XHR interception instead
  • Grep across all .js files confirms zero chrome.webRequest API calls
  • Reduces the extension's privilege surface and avoids unnecessary Chrome Web Store review flags

Test plan

  • Load the extension and verify it installs without errors
  • Confirm NIP-98 auth header injection still works (fetch interception is JS-level, not webRequest-based)
  • Verify NIP-07 signing still works on a Nostr client page

🤖 Generated with claude-flow

The webRequest permission is declared but never used — the code
explicitly notes that webRequestBlocking is deprecated in MV3 and uses
JavaScript-level fetch/XHR interception instead. Removing this
permission reduces the extension's privilege surface and avoids
triggering unnecessary review during Chrome Web Store submission.

Co-Authored-By: claude-flow <ruv@ruv.net>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the unused webRequest permission from the extension’s MV3 manifest.json, reducing requested privileges while keeping the current JS-level interception approach intact.

Changes:

  • Removed "webRequest" from the permissions list in manifest.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@melvincarvalho melvincarvalho merged commit f486aa0 into JavaScriptSolidServer:main May 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants