feat: pass --body-limit 40MB + require jss >=0.0.208 so large app installs fit#80
Merged
Merged
Conversation
…talls fit jspod spawns jss with no --body-limit, so it rode JSS's default cap. That blocked installing apps with a large git history through a pod — e.g. solid-chat/app's ~30MB pack (jss install does a full clone; JSS git-receive rejects shallow pushes), which 413'd against the old 10MB (and even the new 20MB) default. - Pass --body-limit 40MB when spawning jss (overridable via options.bodyLimit). 40MB clears the ~30MB pack with headroom without an over-permissive memory-DoS surface. - Require jss >=0.0.208 <0.0.211: --body-limit only actually reaches Fastify from the CLI as of 0.0.208 (#562) — before that the flag was dead wiring — and the range floats up to 0.0.210 without re-pinning. Bump jspod 0.0.47 → 0.0.48.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
jspod spawns
jsswith no--body-limit, so it rode JSS's default request body cap. That blocked installing apps with a large git history through a pod — e.g.solid-chat/app's ~30MB pack (jss installdoes a full clone because JSS git-receive rejects shallow pushes), which 413'd against the old 10MB and the new 20MB default.Changes
--body-limit 40MBto the spawned jssoptions.bodyLimit. 40MB clears the ~30MB pack with headroom, without an over-permissive memory-DoS surface.^0.0.207→>=0.0.208 <0.0.211--body-limitonly reaches Fastify from the CLI as of 0.0.208 (JSS #562) — before that the flag was dead wiring. Range floats up to 0.0.210 without re-pinning each patch.0.0.47→0.0.48Notes
^0.0.207pinned to exactly 0.0.207 (caret locks the patch on0.0.x), so the explicit range is what lets jspod actually move to 0.0.208+.options.bodyLimitis the escape hatch (no code change needed).