fix(shutdown): stop Ctrl+C output racing the shell prompt#63
Closed
melvincarvalho wants to merge 1 commit into
Closed
fix(shutdown): stop Ctrl+C output racing the shell prompt#63melvincarvalho wants to merge 1 commit into
melvincarvalho wants to merge 1 commit into
Conversation
4 tasks
The JSS child shares the CLI's process group, so a terminal Ctrl+C delivers SIGINT to both. The child already prints "Shutting down..." and exits on its own; the CLI was also printing "Shutting down gracefully..." and then printing the farewell on a fixed 1s timer, which raced the returning shell prompt. Drop the parent's redundant line and wait for the child's real exit before the farewell, so output stays ordered. Same process group, so closing the terminal still tears the server down (no detached orphan). Closes #62
23eaaf6 to
86d51a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62. Stacked on #57 (
issue-56-programmatic-api) — base it there, notgh-pages, because #57 introduces thehandle.stop()shutdown path this fix builds on. Merge #57 first, then this retargets togh-pagesautomatically.Problem
On a terminal Ctrl+C, the JSS child shares the CLI's process group and receives SIGINT too. The child already prints
Shutting down...and exits on its own. The CLI was also printing⚠ Shutting down gracefully..., then racing theGoodbye 👋farewell against the returning shell prompt — so the farewell could land after the prompt, with a duplicated "shutting down" line.Fix
Drop the parent's redundant line.
handle.stop()already awaits the child's exit, so the farewell now prints only once the child is gone — ordered ahead of the prompt.Both processes stay in the same group, so closing the terminal still tears the server down (SIGHUP). Considered and rejected
detached: true: it fixes ordering but orphans the server on terminal close / parent crash, leaving the port held.