Bundle profile + home in the curated apps/ set (offline-first install)#61
Open
melvincarvalho wants to merge 1 commit into
Open
Bundle profile + home in the curated apps/ set (offline-first install)#61melvincarvalho wants to merge 1 commit into
melvincarvalho wants to merge 1 commit into
Conversation
apps/ ships inside the package and seedPodFiles() copies it into the pod on first run — offline, no git, no network. It already carried pilot; add profile and home so embedders (esp. nodejs-mobile/Android via the in-process start, #58/#59) get a useful curated set installed offline at first boot, without the jsDelivr/git network path. Snapshots of each app's gh-pages deployable files (README/LICENSE excluded), matching how apps/pilot is vendored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/ships inside the jspod package andseedPodFiles()copies it into the pod on first run — offline, no git, no network. It already bundledpilot; this addsprofileandhome.Why
For git-less / single-process embedders — especially nodejs-mobile (the Android app, js-pod/android) via the in-process
start()in #58 / #59 — the bundledapps/is the offline-first install path. A pod boots with a useful curated set already installed, with no jsDelivr/git network round-trip. The network install (#60) stays as the path for arbitrary/extra apps and no-release updates.What
Vendored snapshots of each app's
gh-pagesdeployable files (README/LICENSE excluded), matching howapps/pilotis structured:apps/profile/— app.js, index.html, style.css, xlogin.js, manifest.json, favicon.svg, iconsapps/home/— home.js, index.html, manifest.json, favicon.svg, icons, og.pngTradeoffs
Notes
seedPodFiles()already copies the wholeapps/dir on first run.