fix(tunnel): accept ?token= query param on /.tunnel for browser WS auth#529
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #528.
Browser
WebSockets can't set anAuthorizationheader, so a browser-based tunnel client currently can't authenticate to/.tunnel(it getsAuthentication requiredand the socket closes). Only Node clients work today.This mirrors what
/.webrtcalready does: if a?token=query param is present and there's noAuthorizationheader, inject it as aBearertoken before the WebID check.Test
POST /.pods).new WebSocket("wss://<host>/.tunnel?token=<jwt>"), send{type:"register", name:"demo"}.{type:"registered", url:"/tunnel/demo/"};https://<host>/tunnel/demo/proxies to the client.Notes
/.webrtcalready accepts (token in the WS upgrade URL; WebID-bound / short-lived).