Skip to content

test(nostr-cid-vm): make JWK-y corruption provably off-curve (closes #438) #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melvincarvalho merged 1 commit into from
May 19, 2026
Merged

test(nostr-cid-vm): make JWK-y corruption provably off-curve (closes #438) #504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions test/nostr-cid-vm.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,12 @@ describe('NIP-98 + CID verificationMethod lookup (#399)', () => {

it('rejects a JWK with the right x but wrong y (curve-point integrity)', async () => {
const goodJwk = evenYJwk(pk);
// Flip the y to invalid — same x, different y → not on canonical
// BIP-340 point, so should NOT match the Nostr key.
const badJwk = { ...goodJwk, y: goodJwk.y.slice(0, -1) + (goodJwk.y.endsWith('A') ? 'B' : 'A') };
// Force y = 0 (43 'A's = 32 zero bytes). (x, 0) is on secp256k1
// iff x³ ≡ -7 mod p, which has exactly 3 solutions in ~2²⁵⁶ — so
// for any practical x this is provably off-curve. Avoids the flake
// where a single-char flip in y was either a base64url padding-bit
// no-op or, far more rarely, landed on the negation -y mod p.
const badJwk = { ...goodJwk, y: 'A'.repeat(43) };
nextProfile = buildProfile({ pubkey: pk, jwk: badJwk });
const url = `https://${POD_HOST}/private/data.ttl`;
const { authHeader } = nip98Authorization({ method: 'GET', url, secretKey: sk });
Expand Down