git handler: allow Git-Protocol in CORS preflight (#371)#372
Merged
Conversation
Browser git clients on protocol v2 (e.g. isomorphic-git) send a Git-Protocol: version=2 request header. Without it in Access-Control-Allow-Headers, the preflight fails and the smart-HTTP flow never starts cross-origin. Two callsites — the OPTIONS preflight handler and the streaming-response header block both replied with the same hard-coded list. Adding "Git-Protocol" to both. The frontend's protocolVersion: 1 workaround can go away once a server with this fix ships.
There was a problem hiding this comment.
Pull request overview
Adds CORS support for Git smart-HTTP protocol v2 by allowing the Git-Protocol request header in the git handler responses, enabling browser-based git clients (e.g., isomorphic-git) to work without downgrading to protocol v1.
Changes:
- Include
Git-ProtocolinAccess-Control-Allow-Headersfor the git handler’sOPTIONSpreflight response. - Include
Git-ProtocolinAccess-Control-Allow-Headersfor the streaming response path (raw header block).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #371.
Summary
Test plan