--conneg ACL#333
Open
bourgeoa wants to merge 23 commits into
Open
Conversation
- verify_credentials, follow, notifications, home timeline - statuses: create, edit, source, history, permalink, favourite - profile: update_credentials with avatar/header upload - account lookup, search (v1 + v2 with URL resolution), preferences, relationships - lists and account lists endpoints (empty, prevents client null crash) - WebSocket streaming endpoint - OAuth client persistence across restarts - host-meta discovery - Remote account resolution via WebFinger + actor cache - Outbound Follow delivery: HTTP-signed Follow activity to remote inbox - Storage layout: per-pod .ap/activitypub.db, server-wide .idp/ap/keys+oauth - OAuth discovery: /.well-known/oauth-authorization-server - 34 tests passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
--connegfor.aclresources stored as JSON-LD.This should close #327 --conneg render ACL without content
Root cause was in
jsonLdToQuads:@context+@graph, but the conversion only collected top-level nodes with@id, so the ACL graph was skipped and Turtle output contained only prefixes.acl:Readandfoaf:Agentwere not expanded through the JSON-LD context before URI resolution.Changes in this PR:
@graphinjsonLdToQuads@idvalues beforeresolveUriadded regression coverage in conneg.test.js:
.aclJSON-LD documentwebIdreturned bycreateTestPod().aclGETs to match the current JSS rule that ACL access requiresacl:ControlThis now covers the actual failing case: an explicit ACL JSON-LD document with
@graphand CURIE-based values rendered through--connegas Turtle.