findAllReferences: Fix declarationIsWriteAccess for PropertyAssignment in destructuring (microsoft#26949)

Andy · web-flow · commit c401d63c5f0f · 2018-09-06T15:24:07.000-07:00
diff --git a/src/services/findAllReferences.ts b/src/services/findAllReferences.ts
@@ -255,12 +255,15 @@ namespace ts.FindAllReferences {
             case SyntaxKind.NamespaceExportDeclaration:
             case SyntaxKind.NamespaceImport:
             case SyntaxKind.Parameter:
-            case SyntaxKind.PropertyAssignment:
             case SyntaxKind.ShorthandPropertyAssignment:
             case SyntaxKind.TypeAliasDeclaration:
             case SyntaxKind.TypeParameter:
                 return true;
 
+            case SyntaxKind.PropertyAssignment:
+                // In `({ x: y } = 0);`, `x` is not a write access. (Won't call this function for `y`.)
+                return !isArrayLiteralOrObjectLiteralDestructuringPattern((decl as PropertyAssignment).parent);
+
             case SyntaxKind.FunctionDeclaration:
             case SyntaxKind.FunctionExpression:
             case SyntaxKind.Constructor:
diff --git a/tests/cases/fourslash/findAllRefsObjectBindingElementPropertyName07.ts b/tests/cases/fourslash/findAllRefsObjectBindingElementPropertyName07.ts
@@ -2,6 +2,6 @@
 
 ////let p, b;
 ////
-////p, [{ [|{| "isWriteAccess": true, "isDefinition": true |}a|]: p, b }] = [{ [|{| "isWriteAccess": true, "isDefinition": true |}a|]: 10, b: true }];
+////p, [{ [|{| "isDefinition": true |}a|]: p, b }] = [{ [|{| "isWriteAccess": true, "isDefinition": true |}a|]: 10, b: true }];
 
 verify.singleReferenceGroup("(property) a: any");
