Fix JSX completions after boolean property (microsoft#26943)

Andy · web-flow · commit a0ebbfb8f06a · 2018-09-06T14:15:12.000-07:00
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -986,7 +986,10 @@ namespace ts.Completions {
                                 break;
                             case SyntaxKind.Identifier:
                                 // For `<div x=[|f/**/|]`, `parent` will be `x` and `previousToken.parent` will be `f` (which is its own JsxAttribute)
-                                if (parent !== previousToken.parent && !(parent as JsxAttribute).initializer) {
+                                // Note for `<div someBool f>` we don't want to treat this as a jsx inializer, instead it's the attribute name.
+                                if (parent !== previousToken.parent &&
+                                    !(parent as JsxAttribute).initializer &&
+                                    findChildOfKind(parent, SyntaxKind.EqualsToken, sourceFile)) {
                                     isJsxInitializer = previousToken as Identifier;
                                 }
                         }
diff --git a/tests/cases/fourslash/completionsJsxAttribute.ts b/tests/cases/fourslash/completionsJsxAttribute.ts
@@ -8,15 +8,22 @@
 ////    interface IntrinsicElements {
 ////        div: {
 ////            /** Doc */
-////            foo: string
+////            foo: boolean;
+////            bar: string;
 ////        }
 ////    }
 ////}
 ////
 ////<div /**/></div>;
 
-goTo.marker();
-verify.completionEntryDetailIs("foo", "(JSX attribute) foo: string", "Doc", "JSX attribute", []);
+const exact: ReadonlyArray<FourSlashInterface.ExpectedCompletionEntry> = [
+    { name: "foo", kind: "JSX attribute", text: "(JSX attribute) foo: boolean", documentation: "Doc" },
+    { name: "bar", kind: "JSX attribute", text: "(JSX attribute) bar: string" },
+];
+verify.completions({ marker: "", exact });
 edit.insert("f");
-verify.completionEntryDetailIs("foo", "(JSX attribute) foo: string", "Doc", "JSX attribute", []);
-
+verify.completions({ exact });
+edit.insert("oo ");
+verify.completions({ exact: exact[1] });
+edit.insert("b");
+verify.completions({ exact: exact[1] });

Original file line number	Diff line number	Diff line change
`@@ -986,7 +986,10 @@ namespace ts.Completions {`
`986`	`986`	`break;`
`987`	`987`	`case SyntaxKind.Identifier:`
`988`	`988`	// For `<div x=[\|f/**/\|]`, `parent` will be `x` and `previousToken.parent` will be `f` (which is its own JsxAttribute)
`989`		`- if (parent !== previousToken.parent && !(parent as JsxAttribute).initializer) {`
	`989`	+ // Note for `<div someBool f>` we don't want to treat this as a jsx inializer, instead it's the attribute name.
	`990`	`+ if (parent !== previousToken.parent &&`
	`991`	`+ !(parent as JsxAttribute).initializer &&`
	`992`	`+ findChildOfKind(parent, SyntaxKind.EqualsToken, sourceFile)) {`
`990`	`993`	`isJsxInitializer = previousToken as Identifier;`
`991`	`994`	`}`
`992`	`995`	`}`