Fix bug: Still implement a method even if the return type is defined in another file (microsoft#24978)

Andy · web-flow · commit b3f9ec379628 · 2018-06-19T16:36:18.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -4110,15 +4110,14 @@ namespace ts {
                 if (declaration.parent && declaration.parent.kind === SyntaxKind.VariableDeclaration) {
                     return declarationNameToString((<VariableDeclaration>declaration.parent).name);
                 }
-                if (context && !context.encounteredError && !(context.flags & NodeBuilderFlags.AllowAnonymousIdentifier)) {
-                    context.encounteredError = true;
-                }
                 switch (declaration.kind) {
                     case SyntaxKind.ClassExpression:
-                        return "(Anonymous class)";
                     case SyntaxKind.FunctionExpression:
                     case SyntaxKind.ArrowFunction:
-                        return "(Anonymous function)";
+                        if (context && !context.encounteredError && !(context.flags & NodeBuilderFlags.AllowAnonymousIdentifier)) {
+                            context.encounteredError = true;
+                        }
+                        return declaration.kind === SyntaxKind.ClassExpression ? "(Anonymous class)" : "(Anonymous function)";
                 }
             }
             const nameType = symbol.nameType;
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -3066,6 +3066,7 @@ namespace ts {
         Subtype
     }
 
+    // NOTE: If modifying this enum, must modify `TypeFormatFlags` too!
     export const enum NodeBuilderFlags {
         None                                    = 0,
         // Options
diff --git a/tests/cases/fourslash/codeFixClassImplementInterface_typeInOtherFile.ts b/tests/cases/fourslash/codeFixClassImplementInterface_typeInOtherFile.ts
@@ -0,0 +1,25 @@
+/// <reference path='fourslash.ts' />
+
+// @Filename: /I.ts
+////export interface J {}
+////export interface I {
+////    x: J;
+////    m(): J;
+////}
+
+// @Filename: /C.ts
+////import { I } from "./I";
+////export class C implements I {}
+
+goTo.file("/C.ts");
+verify.codeFix({
+    description: "Implement interface 'I'",
+    newFileContent:
+`import { I } from "./I";
+export class C implements I {
+    x: import("/I").J;
+    m(): import("/I").J {
+        throw new Error("Method not implemented.");
+    }
+}`,
+});
diff --git a/tests/cases/fourslash/codeFixInferFromUsageSetterWithInaccessibleType.ts b/tests/cases/fourslash/codeFixInferFromUsageSetterWithInaccessibleType.ts
@@ -13,4 +13,13 @@
 ////}
 
 goTo.file("/b.ts");
-verify.not.codeFixAvailable();
+verify.codeFix({
+    index: 0,
+    description: "Infer type of 'x' from usage",
+    newFileContent:
+`export class C {
+    set x(val: Promise<typeof import("/a")>) { val; }
+    method() { this.x = import("./a"); }
+}`,
+});
+

Original file line number	Diff line number	Diff line change
`@@ -3066,6 +3066,7 @@ namespace ts {`
`3066`	`3066`	`Subtype`
`3067`	`3067`	`}`
`3068`	`3068`
	`3069`	+ // NOTE: If modifying this enum, must modify `TypeFormatFlags` too!
`3069`	`3070`	`export const enum NodeBuilderFlags {`
`3070`	`3071`	`None = 0,`
`3071`	`3072`	`// Options`