Add method signature handler to getTypeOfVariableOrParameterOrProperty (microsoft#20825)

weswigham · web-flow · commit ae211983eb7b · 2017-12-28T19:00:54.000-08:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -4683,7 +4683,8 @@ namespace ts {
                 else if (isJSDocPropertyTag(declaration)
                     || isPropertyAccessExpression(declaration)
                     || isIdentifier(declaration)
-                    || isMethodDeclaration(declaration) && !isObjectLiteralMethod(declaration)) {
+                    || (isMethodDeclaration(declaration) && !isObjectLiteralMethod(declaration))
+                    || isMethodSignature(declaration)) {
                     // TODO: Mimics old behavior from incorrect usage of getWidenedTypeForVariableLikeDeclaration, but seems incorrect
                     type = tryGetTypeFromEffectiveTypeNode(declaration) || anyType;
                 }
diff --git a/tests/baselines/reference/methodSignatureHandledDeclarationKindForSymbol.js b/tests/baselines/reference/methodSignatureHandledDeclarationKindForSymbol.js
@@ -0,0 +1,12 @@
+//// [methodSignatureHandledDeclarationKindForSymbol.ts]
+interface Foo {
+    bold(): string;
+}
+
+interface Foo {
+    bold: string;
+}
+
+
+
+//// [methodSignatureHandledDeclarationKindForSymbol.js]
diff --git a/tests/baselines/reference/methodSignatureHandledDeclarationKindForSymbol.symbols b/tests/baselines/reference/methodSignatureHandledDeclarationKindForSymbol.symbols
@@ -0,0 +1,16 @@
+=== tests/cases/compiler/methodSignatureHandledDeclarationKindForSymbol.ts ===
+interface Foo {
+>Foo : Symbol(Foo, Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 0, 0), Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 2, 1))
+
+    bold(): string;
+>bold : Symbol(Foo.bold, Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 0, 15), Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 4, 15))
+}
+
+interface Foo {
+>Foo : Symbol(Foo, Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 0, 0), Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 2, 1))
+
+    bold: string;
+>bold : Symbol(Foo.bold, Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 0, 15), Decl(methodSignatureHandledDeclarationKindForSymbol.ts, 4, 15))
+}
+
+
diff --git a/tests/baselines/reference/methodSignatureHandledDeclarationKindForSymbol.types b/tests/baselines/reference/methodSignatureHandledDeclarationKindForSymbol.types
@@ -0,0 +1,16 @@
+=== tests/cases/compiler/methodSignatureHandledDeclarationKindForSymbol.ts ===
+interface Foo {
+>Foo : Foo
+
+    bold(): string;
+>bold : string
+}
+
+interface Foo {
+>Foo : Foo
+
+    bold: string;
+>bold : string
+}
+
+
diff --git a/tests/cases/compiler/methodSignatureHandledDeclarationKindForSymbol.ts b/tests/cases/compiler/methodSignatureHandledDeclarationKindForSymbol.ts
@@ -0,0 +1,8 @@
+interface Foo {
+    bold(): string;
+}
+
+interface Foo {
+    bold: string;
+}
+
