microsoft-typescript/boolean-trivia

a-tarasyuk · a-tarasyuk · commit a96a08a3291b · 2019-06-14T11:17:49.000+03:00
diff --git a/.eslintrc b/.eslintrc
@@ -55,7 +55,7 @@
         "microsoft-typescript/type-operator-spacing": "off",
         "microsoft-typescript/only-arrow-functions": "off",
         "microsoft-typescript/no-double-space": "off",
-        "microsoft-typescript/boolean-trivia": "off",
+        "microsoft-typescript/boolean-trivia": "error",
         "microsoft-typescript/no-in-operator": "off",
         "microsoft-typescript/debug-assert": "error",
         "microsoft-typescript/no-keywords": "off",
diff --git a/scripts/word2md.ts b/scripts/word2md.ts
@@ -205,7 +205,18 @@ function convertDocumentToMarkdown(doc: Word.Document): string {
         var replace = find.replacement;
         replace.clearFormatting();
         setProperties(replace, replaceOptions);
-        find.execute(findText, false, false, false, false, false, true, 0, true, replaceText, 2);
+        find.execute(findText,
+            /* matchCase */ false,
+            /* matchWholeWord */ false,
+            /* matchWildcards */ false,
+            /* matchSoundsLike */ false,
+            /* matchAllWordForms */ false,
+            /* forward */ true,
+            0,
+            /* format */ true,
+            replaceText,
+            2
+        );
     }
 
     function fixHyperlinks() {
@@ -405,7 +416,7 @@ function main(args: string[]) {
     var app: Word.Application = sys.createObject("Word.Application");
     var doc = app.documents.open(args[0]);
     sys.writeFile(args[1], convertDocumentToMarkdown(doc));
-    doc.close(false);
+    doc.close(/* saveChanges */ false);
     app.quit();
 }
 
diff --git a/src/compiler/sourcemap.ts b/src/compiler/sourcemap.ts
@@ -73,7 +73,7 @@ namespace ts {
             if (content !== null) {
                 if (!sourcesContent) sourcesContent = [];
                 while (sourcesContent.length < sourceIndex) {
-                    // tslint:disable-next-line:no-null-keyword boolean-trivia
+                    // eslint-disable-next-line microsoft-typescript/boolean-trivia
                     sourcesContent.push(null);
                 }
                 sourcesContent[sourceIndex] = content;

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ namespace ts {`
`73`	`73`	`if (content !== null) {`
`74`	`74`	`if (!sourcesContent) sourcesContent = [];`
`75`	`75`	`while (sourcesContent.length < sourceIndex) {`
`76`		`- // tslint:disable-next-line:no-null-keyword boolean-trivia`
	`76`	`+ // eslint-disable-next-line microsoft-typescript/boolean-trivia`
`77`	`77`	`sourcesContent.push(null);`
`78`	`78`	`}`
`79`	`79`	`sourcesContent[sourceIndex] = content;`