no-new-func

a-tarasyuk · a-tarasyuk · commit 4e6fb7273775 · 2019-06-14T11:02:15.000+03:00
diff --git a/.eslintrc b/.eslintrc
@@ -88,7 +88,7 @@
         "no-fallthrough": "off",
         "no-invalid-this": "off",
         "no-multiple-empty-lines": "off",
-        "no-new-func": "off",
+        "no-new-func": "error",
         "no-new-wrappers": "error",
         "no-redeclare": "off",
         "no-return-await": "error",
diff --git a/src/harness/fourslash.ts b/src/harness/fourslash.ts
@@ -600,7 +600,7 @@ namespace FourSlash {
                 throw new Error("Expected exactly one output from emit of " + this.activeFile.fileName);
             }
 
-            const evaluation = new Function(`${emit.outputFiles[0].text};\r\nreturn (${expr});`)(); // tslint:disable-line:function-constructor
+            const evaluation = new Function(`${emit.outputFiles[0].text};\r\nreturn (${expr});`)(); // eslint-disable-line no-new-func
             if (evaluation !== value) {
                 this.raiseError(`Expected evaluation of expression "${expr}" to equal "${value}", but got "${evaluation}"`);
             }
diff --git a/src/harness/harness.ts b/src/harness/harness.ts
@@ -28,7 +28,7 @@ var assert: typeof _chai.assert = _chai.assert;
     };
 }
 
-var global: NodeJS.Global = Function("return this").call(undefined); // tslint:disable-line:function-constructor
+var global: NodeJS.Global = Function("return this").call(undefined); // eslint-disable-line no-new-func
 
 declare var window: {};
 declare var XMLHttpRequest: new() => XMLHttpRequest;

Original file line number	Diff line number	Diff line change
`@@ -600,7 +600,7 @@ namespace FourSlash {`
`600`	`600`	`throw new Error("Expected exactly one output from emit of " + this.activeFile.fileName);`
`601`	`601`	`}`
`602`	`602`
`603`		- const evaluation = new Function(`${emit.outputFiles[0].text};\r\nreturn (${expr});`)(); // tslint:disable-line:function-constructor
	`603`	+ const evaluation = new Function(`${emit.outputFiles[0].text};\r\nreturn (${expr});`)(); // eslint-disable-line no-new-func
`604`	`604`	`if (evaluation !== value) {`
`605`	`605`	this.raiseError(`Expected evaluation of expression "${expr}" to equal "${value}", but got "${evaluation}"`);
`606`	`606`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ var assert: typeof _chai.assert = _chai.assert;`
`28`	`28`	`};`
`29`	`29`	`}`
`30`	`30`
`31`		`-var global: NodeJS.Global = Function("return this").call(undefined); // tslint:disable-line:function-constructor`
	`31`	`+var global: NodeJS.Global = Function("return this").call(undefined); // eslint-disable-line no-new-func`
`32`	`32`
`33`	`33`	`declare var window: {};`
`34`	`34`	`declare var XMLHttpRequest: new() => XMLHttpRequest;`