Skip to content

Commit 97d7aa5

Browse files
mhegazymhegazy
authored
Merge pull request microsoft#9042 from Microsoft/ES6ModulesES5Target
Fix microsoft#6319: Add support for `--t: es5` and `--m es6`
2 parents 71b7d44 + f0a430a commit 97d7aa5

50 files changed

Lines changed: 850 additions & 32 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/compiler/diagnosticMessages.json‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -635,10 +635,6 @@
635635
"category": "Error",
636636
"code": 1203
637637
},
638-
"Cannot compile modules into 'es2015' when targeting 'ES5' or lower.": {
639-
"category": "Error",
640-
"code": 1204
641-
},
642638
"Decorators are not valid here.": {
643639
"category": "Error",
644640
"code": 1206

‎src/compiler/emitter.ts‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5613,7 +5613,11 @@ const _super = (function (geti, seti) {
56135613
}
56145614

56155615
function emitClassLikeDeclarationBelowES6(node: ClassLikeDeclaration) {
5616+
const isES6ExportedClass = isES6ExportedDeclaration(node);
56165617
if (node.kind === SyntaxKind.ClassDeclaration) {
5618+
if (isES6ExportedClass && !(node.flags & NodeFlags.Default)) {
5619+
write("export ");
5620+
}
56175621
// source file level classes in system modules are hoisted so 'var's for them are already defined
56185622
if (!shouldHoistDeclarationInSystemJsModule(node)) {
56195623
write("var ");
@@ -5683,9 +5687,15 @@ const _super = (function (geti, seti) {
56835687
}
56845688
emitEnd(node);
56855689

5686-
if (node.kind === SyntaxKind.ClassDeclaration) {
5690+
if (node.kind === SyntaxKind.ClassDeclaration && !isES6ExportedClass) {
56875691
emitExportMemberAssignment(<ClassDeclaration>node);
56885692
}
5693+
else if (isES6ExportedClass && (node.flags & NodeFlags.Default)) {
5694+
writeLine();
5695+
write("export default ");
5696+
emitDeclarationName(node);
5697+
write(";");
5698+
}
56895699
}
56905700

56915701
function emitClassMemberPrefix(node: ClassLikeDeclaration, member: Node) {

‎src/compiler/program.ts‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2160,11 +2160,6 @@ namespace ts {
21602160
programDiagnostics.add(createFileDiagnostic(firstExternalModuleSourceFile, span.start, span.length, Diagnostics.Cannot_use_imports_exports_or_module_augmentations_when_module_is_none));
21612161
}
21622162

2163-
// Cannot specify module gen target of es6 when below es6
2164-
if (options.module === ModuleKind.ES6 && languageVersion < ScriptTarget.ES6) {
2165-
programDiagnostics.add(createCompilerDiagnostic(Diagnostics.Cannot_compile_modules_into_es2015_when_targeting_ES5_or_lower));
2166-
}
2167-
21682163
// Cannot specify module gen that isn't amd or system with --out
21692164
if (outFile) {
21702165
if (options.module && !(options.module === ModuleKind.AMD || options.module === ModuleKind.System)) {

‎tests/baselines/reference/es5andes6module.errors.txt‎

Lines changed: 0 additions & 19 deletions
This file was deleted.

‎tests/baselines/reference/es5andes6module.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ var A = (function () {
2323
};
2424
return A;
2525
}());
26-
exports.default = A;
26+
export default A;

‎tests/baselines/reference/es5andes6module.symbols‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
=== tests/cases/compiler/es5andes6module.ts ===
2+
3+
export default class A
4+
>A : Symbol(A, Decl(es5andes6module.ts, 0, 0))
5+
{
6+
constructor ()
7+
{
8+
9+
}
10+
11+
public B()
12+
>B : Symbol(A.B, Decl(es5andes6module.ts, 6, 5))
13+
{
14+
return 42;
15+
}
16+
}
17+

‎tests/baselines/reference/es5andes6module.types‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
=== tests/cases/compiler/es5andes6module.ts ===
2+
3+
export default class A
4+
>A : A
5+
{
6+
constructor ()
7+
{
8+
9+
}
10+
11+
public B()
12+
>B : () => number
13+
{
14+
return 42;
15+
>42 : number
16+
}
17+
}
18+

‎tests/baselines/reference/es6modulekindWithES5Target.js‎

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
//// [es6modulekindWithES5Target.ts]
2+
3+
export class C {
4+
static s = 0;
5+
p = 1;
6+
method() { }
7+
}
8+
export { C as C2 };
9+
10+
declare function foo(...args: any[]): any;
11+
@foo
12+
export class D {
13+
static s = 0;
14+
p = 1;
15+
method() { }
16+
}
17+
export { D as D2 };
18+
19+
class E { }
20+
export {E};
21+
22+
23+
//// [es6modulekindWithES5Target.js]
24+
var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
25+
var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
26+
if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
27+
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
28+
return c > 3 && r && Object.defineProperty(target, key, r), r;
29+
};
30+
export var C = (function () {
31+
function C() {
32+
this.p = 1;
33+
}
34+
C.prototype.method = function () { };
35+
C.s = 0;
36+
return C;
37+
}());
38+
export { C as C2 };
39+
export var D = (function () {
40+
function D() {
41+
this.p = 1;
42+
}
43+
D.prototype.method = function () { };
44+
D.s = 0;
45+
D = __decorate([
46+
foo
47+
], D);
48+
return D;
49+
}());
50+
export { D as D2 };
51+
var E = (function () {
52+
function E() {
53+
}
54+
return E;
55+
}());
56+
export { E };

‎tests/baselines/reference/es6modulekindWithES5Target.symbols‎

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
=== tests/cases/compiler/es6modulekindWithES5Target.ts ===
2+
3+
export class C {
4+
>C : Symbol(C, Decl(es6modulekindWithES5Target.ts, 0, 0))
5+
6+
static s = 0;
7+
>s : Symbol(C.s, Decl(es6modulekindWithES5Target.ts, 1, 16))
8+
9+
p = 1;
10+
>p : Symbol(C.p, Decl(es6modulekindWithES5Target.ts, 2, 17))
11+
12+
method() { }
13+
>method : Symbol(C.method, Decl(es6modulekindWithES5Target.ts, 3, 10))
14+
}
15+
export { C as C2 };
16+
>C : Symbol(C2, Decl(es6modulekindWithES5Target.ts, 6, 8))
17+
>C2 : Symbol(C2, Decl(es6modulekindWithES5Target.ts, 6, 8))
18+
19+
declare function foo(...args: any[]): any;
20+
>foo : Symbol(foo, Decl(es6modulekindWithES5Target.ts, 6, 19))
21+
>args : Symbol(args, Decl(es6modulekindWithES5Target.ts, 8, 21))
22+
23+
@foo
24+
>foo : Symbol(foo, Decl(es6modulekindWithES5Target.ts, 6, 19))
25+
26+
export class D {
27+
>D : Symbol(D, Decl(es6modulekindWithES5Target.ts, 8, 42))
28+
29+
static s = 0;
30+
>s : Symbol(D.s, Decl(es6modulekindWithES5Target.ts, 10, 16))
31+
32+
p = 1;
33+
>p : Symbol(D.p, Decl(es6modulekindWithES5Target.ts, 11, 17))
34+
35+
method() { }
36+
>method : Symbol(D.method, Decl(es6modulekindWithES5Target.ts, 12, 10))
37+
}
38+
export { D as D2 };
39+
>D : Symbol(D2, Decl(es6modulekindWithES5Target.ts, 15, 8))
40+
>D2 : Symbol(D2, Decl(es6modulekindWithES5Target.ts, 15, 8))
41+
42+
class E { }
43+
>E : Symbol(E, Decl(es6modulekindWithES5Target.ts, 15, 19))
44+
45+
export {E};
46+
>E : Symbol(E, Decl(es6modulekindWithES5Target.ts, 18, 8))
47+

‎tests/baselines/reference/es6modulekindWithES5Target.types‎

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
=== tests/cases/compiler/es6modulekindWithES5Target.ts ===
2+
3+
export class C {
4+
>C : C
5+
6+
static s = 0;
7+
>s : number
8+
>0 : number
9+
10+
p = 1;
11+
>p : number
12+
>1 : number
13+
14+
method() { }
15+
>method : () => void
16+
}
17+
export { C as C2 };
18+
>C : typeof C
19+
>C2 : typeof C
20+
21+
declare function foo(...args: any[]): any;
22+
>foo : (...args: any[]) => any
23+
>args : any[]
24+
25+
@foo
26+
>foo : (...args: any[]) => any
27+
28+
export class D {
29+
>D : D
30+
31+
static s = 0;
32+
>s : number
33+
>0 : number
34+
35+
p = 1;
36+
>p : number
37+
>1 : number
38+
39+
method() { }
40+
>method : () => void
41+
}
42+
export { D as D2 };
43+
>D : typeof D
44+
>D2 : typeof D
45+
46+
class E { }
47+
>E : E
48+
49+
export {E};
50+
>E : typeof E
51+

0 commit comments

Comments
 (0)