Fix find-all-references for destructured getter (microsoft#17483)

Andy · web-flow · commit 4f13bcfac1bb · 2017-08-02T06:51:26.000-07:00
* Fix find-all-references for destructured getter

* Handle setter too

* Use SymbolFlags.Accessor
diff --git a/src/services/findAllReferences.ts b/src/services/findAllReferences.ts
@@ -604,11 +604,16 @@ namespace ts.FindAllReferences.Core {
 
     function getPropertySymbolOfObjectBindingPatternWithoutPropertyName(symbol: Symbol, checker: TypeChecker): Symbol | undefined {
         const bindingElement = getObjectBindingElementWithoutPropertyName(symbol);
-        if (bindingElement) {
-            const typeOfPattern = checker.getTypeAtLocation(bindingElement.parent);
-            return typeOfPattern && checker.getPropertyOfType(typeOfPattern, (<Identifier>bindingElement.name).text);
+        if (!bindingElement) return undefined;
+
+        const typeOfPattern = checker.getTypeAtLocation(bindingElement.parent);
+        const propSymbol = typeOfPattern && checker.getPropertyOfType(typeOfPattern, (<Identifier>bindingElement.name).text);
+        if (propSymbol && propSymbol.flags & SymbolFlags.Accessor) {
+            // See GH#16922
+            Debug.assert(!!(propSymbol.flags & SymbolFlags.Transient));
+            return (propSymbol as TransientSymbol).target;
         }
-        return undefined;
+        return propSymbol;
     }
 
     /**
diff --git a/tests/cases/fourslash/findAllRefsDestructureGetter.ts b/tests/cases/fourslash/findAllRefsDestructureGetter.ts
@@ -0,0 +1,22 @@
+/// <reference path="fourslash.ts" />
+
+////class Test {
+////    get [|{| "isDefinition": true, "isWriteAccess": true |}x|]() { return 0; }
+////
+////    set [|{| "isDefinition": true, "isWriteAccess": true |}y|](a: number) {}
+////}
+////const { [|{| "isDefinition": true, "isWriteAccess": true |}x|], [|{| "isDefinition": true, "isWriteAccess": true |}y|] } = new Test();
+////[|x|]; [|y|];
+
+const [x0, y0, x1, y1, x2, y2] = test.ranges();
+verify.referenceGroups(x0, [{ definition: "(property) Test.x: number", ranges: [x0, x1, x2] }]);
+verify.referenceGroups([x1, x2], [
+    { definition: "(property) Test.x: number", ranges: [x0] },
+    { definition: "const x: number", ranges: [x1, x2] },
+]);
+
+verify.referenceGroups(y0, [{ definition: "(property) Test.y: number", ranges: [y0, y1, y2] }]);
+verify.referenceGroups([y1, y2], [
+    { definition: "(property) Test.y: number", ranges: [y0] },
+    { definition: "const y: number", ranges: [y1, y2] },
+]);
