fix microsoft#11463, null assertion block uninitialized error (microsoft#14020)

HerringtonDarkholme · mhegazy · commit 2f65b2c160c3 · 2017-05-23T14:13:32.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -12035,6 +12035,7 @@ namespace ts {
             // declaration container are the same).
             const assumeInitialized = isParameter || isOuterVariable ||
                 type !== autoType && type !== autoArrayType && (!strictNullChecks || (type.flags & TypeFlags.Any) !== 0 || isInTypeQuery(node) || node.parent.kind === SyntaxKind.ExportSpecifier) ||
+                node.parent.kind === SyntaxKind.NonNullExpression ||
                 isInAmbientContext(declaration);
             const initialType = assumeInitialized ? (isParameter ? removeOptionalityFromDeclaredType(type, getRootDeclaration(declaration) as VariableLikeDeclaration) : type) :
                 type === autoType || type === autoArrayType ? undefinedType :
diff --git a/tests/baselines/reference/typeGuardsAsAssertions.js b/tests/baselines/reference/typeGuardsAsAssertions.js
@@ -119,6 +119,11 @@ function f6() {
     x = <string | null>"";
     x!.slice();
 }
+
+function f7() {
+    let x: string;
+    x!.slice();
+}
 
 
 //// [typeGuardsAsAssertions.js]
@@ -227,3 +232,7 @@ function f6() {
     x = "";
     x.slice();
 }
+function f7() {
+    var x;
+    x.slice();
+}
diff --git a/tests/baselines/reference/typeGuardsAsAssertions.symbols b/tests/baselines/reference/typeGuardsAsAssertions.symbols
@@ -312,3 +312,15 @@ function f6() {
 >slice : Symbol(String.slice, Decl(lib.d.ts, --, --))
 }
 
+function f7() {
+>f7 : Symbol(f7, Decl(typeGuardsAsAssertions.ts, 119, 1))
+
+    let x: string;
+>x : Symbol(x, Decl(typeGuardsAsAssertions.ts, 122, 7))
+
+    x!.slice();
+>x!.slice : Symbol(String.slice, Decl(lib.d.ts, --, --))
+>x : Symbol(x, Decl(typeGuardsAsAssertions.ts, 122, 7))
+>slice : Symbol(String.slice, Decl(lib.d.ts, --, --))
+}
+
diff --git a/tests/baselines/reference/typeGuardsAsAssertions.types b/tests/baselines/reference/typeGuardsAsAssertions.types
@@ -382,3 +382,17 @@ function f6() {
 >slice : (start?: number | undefined, end?: number | undefined) => string
 }
 
+function f7() {
+>f7 : () => void
+
+    let x: string;
+>x : string
+
+    x!.slice();
+>x!.slice() : string
+>x!.slice : (start?: number | undefined, end?: number | undefined) => string
+>x! : string
+>x : string
+>slice : (start?: number | undefined, end?: number | undefined) => string
+}
+
diff --git a/tests/cases/conformance/controlFlow/typeGuardsAsAssertions.ts b/tests/cases/conformance/controlFlow/typeGuardsAsAssertions.ts
@@ -120,3 +120,8 @@ function f6() {
     x = <string | null>"";
     x!.slice();
 }
+
+function f7() {
+    let x: string;
+    x!.slice();
+}

Original file line number	Diff line number	Diff line change
`@@ -120,3 +120,8 @@ function f6() {`
`120`	`120`	`x = <string \| null>"";`
`121`	`121`	`x!.slice();`
`122`	`122`	`}`
	`123`	`+`
	`124`	`+function f7() {`
	`125`	`+ let x: string;`
	`126`	`+ x!.slice();`
	`127`	`+}`