Add setInterval/setTimeout

RyanCavanaugh · RyanCavanaugh · commit 02a5ef6a179c · 2019-02-11T11:26:19.000-08:00
diff --git a/src/harness/harnessLanguageService.ts b/src/harness/harnessLanguageService.ts
@@ -766,6 +766,7 @@ namespace Harness.LanguageService {
         }
 
         setTimeout(callback: (...args: any[]) => void, ms: number, ...args: any[]): any {
+            // tslint:disable-next-line:ban
             return setTimeout(callback, ms, args);
         }
 
diff --git a/src/testRunner/parallel/host.ts b/src/testRunner/parallel/host.ts
@@ -302,6 +302,7 @@ namespace Harness.Parallel.Host {
                                 worker.timer = undefined;
                             }
                             else {
+                                // tslint:disable-next-line:ban
                                 worker.timer = setTimeout(killChild, data.payload.duration, data.payload);
                             }
                             break;
@@ -623,6 +624,7 @@ namespace Harness.Parallel.Host {
             shimNoopTestInterface(global);
         }
 
+        // tslint:disable-next-line:ban
         setTimeout(() => startDelayed(perfData, totalCost), 0); // Do real startup on next tick, so all unit tests have been collected
     }
 }
diff --git a/src/tsserver/server.ts b/src/tsserver/server.ts
@@ -705,6 +705,7 @@ namespace ts.server {
         // stat due to inconsistencies of fs.watch
         // and efficiency of stat on modern filesystems
         function startWatchTimer() {
+            // tslint:disable-next-line:ban
             setInterval(() => {
                 let count = 0;
                 let nextToCheck = nextFileToCheck;
diff --git a/tslint.json b/tslint.json
@@ -5,6 +5,11 @@
         "no-unnecessary-type-assertion": true,
 
         "array-type": [true, "array"],
+        "ban": [
+            true,
+            "setInterval",
+            "setTimeout"
+        ],
         "ban-types": {
             "options": [
                 ["Object", "Avoid using the `Object` type. Did you mean `object`?"],

Original file line number	Diff line number	Diff line change
`@@ -766,6 +766,7 @@ namespace Harness.LanguageService {`
`766`	`766`	`}`
`767`	`767`
`768`	`768`	`setTimeout(callback: (...args: any[]) => void, ms: number, ...args: any[]): any {`
	`769`	`+ // tslint:disable-next-line:ban`
`769`	`770`	`return setTimeout(callback, ms, args);`
`770`	`771`	`}`
`771`	`772`
Original file line number	Diff line number	Diff line change
`@@ -302,6 +302,7 @@ namespace Harness.Parallel.Host {`
`302`	`302`	`worker.timer = undefined;`
`303`	`303`	`}`
`304`	`304`	`else {`
	`305`	`+ // tslint:disable-next-line:ban`
`305`	`306`	`worker.timer = setTimeout(killChild, data.payload.duration, data.payload);`
`306`	`307`	`}`
`307`	`308`	`break;`
`@@ -623,6 +624,7 @@ namespace Harness.Parallel.Host {`
`623`	`624`	`shimNoopTestInterface(global);`
`624`	`625`	`}`
`625`	`626`
	`627`	`+ // tslint:disable-next-line:ban`
`626`	`628`	`setTimeout(() => startDelayed(perfData, totalCost), 0); // Do real startup on next tick, so all unit tests have been collected`
`627`	`629`	`}`
`628`	`630`	`}`