Enable no-eval rule

RyanCavanaugh · RyanCavanaugh · commit 1f10e74abc0a · 2019-02-11T11:18:29.000-08:00
diff --git a/src/harness/evaluator.ts b/src/harness/evaluator.ts
@@ -56,6 +56,7 @@ namespace evaluator {
         }
 
         const evaluateText = `(function (module, exports, require, __dirname, __filename, ${globalNames.join(", ")}) { ${output.text} })`;
+        // tslint:disable-next-line:no-eval
         const evaluateThunk = eval(evaluateText) as (module: any, exports: any, require: (id: string) => any, dirname: string, filename: string, ...globalArgs: any[]) => void;
         const module: { exports: any; } = { exports: {} };
         evaluateThunk.call(globals, module, module.exports, noRequire, vpath.dirname(output.file), output.file, FakeSymbol, ...globalArgs);
diff --git a/src/harness/fourslash.ts b/src/harness/fourslash.ts
@@ -3159,6 +3159,7 @@ ${code}
             const debug = new FourSlashInterface.Debug(state);
             const format = new FourSlashInterface.Format(state);
             const cancellation = new FourSlashInterface.Cancellation(state);
+            // tslint:disable-next-line:no-eval
             const f = eval(wrappedCode);
             f(test, goTo, plugins, verify, edit, debug, format, cancellation, FourSlashInterface.Classification, FourSlashInterface.Completion, verifyOperationIsCancelled);
         }
diff --git a/src/harness/harness.ts b/src/harness/harness.ts
@@ -77,6 +77,7 @@ namespace Utils {
         const environment = getExecutionEnvironment();
         switch (environment) {
             case ExecutionEnvironment.Browser:
+                // tslint:disable-next-line:no-eval
                 eval(fileContents);
                 break;
             case ExecutionEnvironment.Node:
diff --git a/tslint.json b/tslint.json
@@ -34,6 +34,7 @@
         ],
         "no-bom": true,
         "no-double-space": true,
+        "no-eval": true,
         "no-in-operator": true,
         "no-increment-decrement": true,
         "no-inferrable-types": true,
@@ -100,7 +101,6 @@
         "no-console": false,
         "no-debugger": false,
         "no-empty-interface": false,
-        "no-eval": false,
         "no-object-literal-type-assertion": false,
         "no-shadowed-variable": false,
         "no-submodule-imports": false,

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@ namespace evaluator {`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	const evaluateText = `(function (module, exports, require, __dirname, __filename, ${globalNames.join(", ")}) { ${output.text} })`;
	`59`	`+ // tslint:disable-next-line:no-eval`
`59`	`60`	`const evaluateThunk = eval(evaluateText) as (module: any, exports: any, require: (id: string) => any, dirname: string, filename: string, ...globalArgs: any[]) => void;`
`60`	`61`	`const module: { exports: any; } = { exports: {} };`
`61`	`62`	`evaluateThunk.call(globals, module, module.exports, noRequire, vpath.dirname(output.file), output.file, FakeSymbol, ...globalArgs);`
Original file line number	Diff line number	Diff line change
`@@ -3159,6 +3159,7 @@ ${code}`
`3159`	`3159`	`const debug = new FourSlashInterface.Debug(state);`
`3160`	`3160`	`const format = new FourSlashInterface.Format(state);`
`3161`	`3161`	`const cancellation = new FourSlashInterface.Cancellation(state);`
	`3162`	`+ // tslint:disable-next-line:no-eval`
`3162`	`3163`	`const f = eval(wrappedCode);`
`3163`	`3164`	`f(test, goTo, plugins, verify, edit, debug, format, cancellation, FourSlashInterface.Classification, FourSlashInterface.Completion, verifyOperationIsCancelled);`
`3164`	`3165`	`}`