Merge pull request webpack#6922 from mohsen1/map-not-weakmap

sokra · web-flow · commit f1993f45759d · 2018-04-04T11:19:37.000+02:00
Use a Map for dependencyTemplatesHashMap instead of a WeakMap
diff --git a/lib/NormalModule.js b/lib/NormalModule.js
@@ -61,8 +61,6 @@ class NonErrorEmittedError extends WebpackError {
 	}
 }
 
-const dependencyTemplatesHashMap = new WeakMap();
-
 class NormalModule extends Module {
 	constructor({
 		type,
@@ -399,7 +397,7 @@ class NormalModule extends Module {
 	}
 
 	getHashDigest(dependencyTemplates) {
-		let dtHash = dependencyTemplatesHashMap.get("hash");
+		let dtHash = dependencyTemplates.get("hash");
 		return `${this.hash}-${dtHash}`;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -61,8 +61,6 @@ class NonErrorEmittedError extends WebpackError {`
`61`	`61`	`}`
`62`	`62`	`}`
`63`	`63`
`64`		`-const dependencyTemplatesHashMap = new WeakMap();`
`65`		`-`
`66`	`64`	`class NormalModule extends Module {`
`67`	`65`	`constructor({`
`68`	`66`	`type,`
`@@ -399,7 +397,7 @@ class NormalModule extends Module {`
`399`	`397`	`}`
`400`	`398`
`401`	`399`	`getHashDigest(dependencyTemplates) {`
`402`		`- let dtHash = dependencyTemplatesHashMap.get("hash");`
	`400`	`+ let dtHash = dependencyTemplates.get("hash");`
`403`	`401`	return `${this.hash}-${dtHash}`;
`404`	`402`	`}`
`405`	`403`