CR feedback

Mohsen Azimi · Mohsen Azimi · commit 7bc38d4bf416 · 2018-04-03T21:14:18.000-07:00
diff --git a/lib/NormalModule.js b/lib/NormalModule.js
@@ -61,9 +61,6 @@ class NonErrorEmittedError extends WebpackError {
 	}
 }
 
-/** @type {Map<string, string>} */
-const dependencyTemplatesHashMap = new Map();
-
 class NormalModule extends Module {
 	constructor({
 		type,
@@ -400,7 +397,7 @@ class NormalModule extends Module {
 	}
 
 	getHashDigest(dependencyTemplates) {
-		let dtHash = dependencyTemplatesHashMap.get("hash");
+		let dtHash = dependencyTemplates.get("hash");
 		return `${this.hash}-${dtHash}`;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -61,9 +61,6 @@ class NonErrorEmittedError extends WebpackError {`
`61`	`61`	`}`
`62`	`62`	`}`
`63`	`63`
`64`		`-/** @type {Map<string, string>} */`
`65`		`-const dependencyTemplatesHashMap = new Map();`
`66`		`-`
`67`	`64`	`class NormalModule extends Module {`
`68`	`65`	`constructor({`
`69`	`66`	`type,`
`@@ -400,7 +397,7 @@ class NormalModule extends Module {`
`400`	`397`	`}`
`401`	`398`
`402`	`399`	`getHashDigest(dependencyTemplates) {`
`403`		`- let dtHash = dependencyTemplatesHashMap.get("hash");`
	`400`	`+ let dtHash = dependencyTemplates.get("hash");`
`404`	`401`	return `${this.hash}-${dtHash}`;
`405`	`402`	`}`
`406`	`403`