transfer add logic for module, block, parent, chunk to prototype

timse · timse · commit 779c753baf5b · 2017-02-14T21:16:08.000+11:00
bringing the "adder" logic to the prototype might be slighly better performance wise
reuse of logic for add module and block, though they now have one superfluous check (should be negligable though)
diff --git a/lib/Chunk.js b/lib/Chunk.js
@@ -29,8 +29,6 @@ class Chunk {
 		this.origins = [];
 		this.files = [];
 		this.rendered = false;
-		this.addChunk = this.createAdder("chunks");
-		this.addParent = this.createAdder("parents");
 		if(module) {
 			this.origins.push({
 				module,
@@ -40,20 +38,6 @@ class Chunk {
 		}
 	}
 
-	createAdder(collection) {
-		const createAdderCallback = (chunk) => {
-			if(chunk === this) {
-				return false;
-			}
-			if(this[collection].indexOf(chunk) >= 0) {
-				return false;
-			}
-			this[collection].push(chunk);
-			return true;
-		};
-		return createAdderCallback;
-	}
-
 	get entry() {
 		throw new Error("Chunk.entry was removed. Use hasRuntime()");
 	}
@@ -83,14 +67,35 @@ class Chunk {
 		return !!this.entryModule;
 	}
 
-	addModule(module) {
-		if(this.modules.indexOf(module) >= 0) {
+	addToCollection(collection, item) {
+		if(item === this) {
+			return false;
+		}
+
+		if(collection.indexOf(item) > -1) {
 			return false;
 		}
-		this.modules.push(module);
+
+		collection.push(item);
 		return true;
 	}
 
+	addChunk(chunk) {
+		return this.addToCollection(this.chunks, chunk);
+	}
+
+	addParent(parent) {
+		return this.addToCollection(this.parents, parent);
+	}
+
+	addModule(module) {
+		return this.addToCollection(this.modules, module);
+	}
+
+	addBlock(block) {
+		return this.addToCollection(this.blocks, block);
+	}
+
 	removeModule(module) {
 		removeAndDo(this.modules, module, "removeChunk", this);
 	}
@@ -103,14 +108,6 @@ class Chunk {
 		removeAndDo(this.parents, chunk, "removeChunk", this);
 	}
 
-	addBlock(block) {
-		if(this.blocks.indexOf(block) >= 0) {
-			return false;
-		}
-		this.blocks.push(block);
-		return true;
-	}
-
 	addOrigin(module, loc) {
 		this.origins.push({
 			module,
