merge iteration of parent and sub chunks

timse · timse · commit 071b504a8450 · 2017-02-14T21:16:08.000+11:00
merge and document iteration over parent and subchunks in remove method
this will slightly increase performance for removing chunks as it only
iterates once over all chunks and parents'
diff --git a/lib/Chunk.js b/lib/Chunk.js
@@ -120,27 +120,39 @@ class Chunk {
 	}
 
 	remove(reason) {
+		// cleanup modules
 		this.modules.slice().forEach(module => {
 			module.removeChunk(this);
 		});
+
+		// cleanup parents
 		this.parents.forEach(parent => {
+			// remove this chunk from its parents
 			const idx = parent.chunks.indexOf(this);
 			if(idx >= 0) {
 				parent.chunks.splice(idx, 1);
 			}
+
+			// cleanup "sub chunks"
 			this.chunks.forEach(chunk => {
+				/**
+				 * remove this chunk as "intermediary" and connect
+				 * it "sub chunks" and parents directly
+				 */
+				// add parent to each "sub chunk"
 				chunk.addParent(parent);
-			});
-		});
-		this.chunks.forEach(chunk => {
-			const idx = chunk.parents.indexOf(this);
-			if(idx >= 0) {
-				chunk.parents.splice(idx, 1);
-			}
-			this.parents.forEach(parent => {
+				// add "sub chunk" to parent
 				parent.addChunk(chunk);
+
+				// remove this as parent of every "sub chunk"
+				const idx = chunk.parents.indexOf(this);
+				if(idx >= 0) {
+					chunk.parents.splice(idx, 1);
+				}
 			});
 		});
+
+		// cleanup blocks
 		this.blocks.forEach(block => {
 			const idx = block.chunks.indexOf(this);
 			if(idx >= 0) {
